Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: Source/core/loader/TextTrackLoader.cpp

Issue 48113029: Use a TextTrackLoaderClient reference (not pointer) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@rmTextTrackResource
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/TextTrackLoader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/TextTrackLoader.cpp
diff --git a/Source/core/loader/TextTrackLoader.cpp b/Source/core/loader/TextTrackLoader.cpp
index f6b675eff849b2e65c9692b764dcf1fae20dc9f7..1d442a7e0defe393c0ee8723c98c320529eaf504 100644
--- a/Source/core/loader/TextTrackLoader.cpp
+++ b/Source/core/loader/TextTrackLoader.cpp
@@ -39,7 +39,7 @@
namespace WebCore {
-TextTrackLoader::TextTrackLoader(TextTrackLoaderClient* client, Document& document)
+TextTrackLoader::TextTrackLoader(TextTrackLoaderClient& client, Document& document)
: m_client(client)
, m_document(document)
, m_cueLoadTimer(this, &TextTrackLoader::cueLoadTimerFired)
@@ -60,11 +60,11 @@ void TextTrackLoader::cueLoadTimerFired(Timer<TextTrackLoader>* timer)
if (m_newCuesAvailable) {
m_newCuesAvailable = false;
- m_client->newCuesAvailable(this);
+ m_client.newCuesAvailable(this);
}
if (m_state >= Finished)
- m_client->cueLoadingCompleted(this, m_state == Failed);
+ m_client.cueLoadingCompleted(this, m_state == Failed);
}
void TextTrackLoader::cancelLoad()
@@ -119,7 +119,7 @@ bool TextTrackLoader::load(const KURL& url, const String& crossOriginMode)
{
cancelLoad();
- if (!m_client->shouldLoadCues(this))
+ if (!m_client.shouldLoadCues(this))
return false;
FetchRequest cueRequest(ResourceRequest(m_document.completeURL(url)), FetchInitiatorTypeNames::texttrack);
@@ -141,7 +141,7 @@ bool TextTrackLoader::load(const KURL& url, const String& crossOriginMode)
if (m_resource)
m_resource->addClient(this);
- m_client->cueLoadingStarted(this);
+ m_client.cueLoadingStarted(this);
return true;
}
@@ -157,7 +157,7 @@ void TextTrackLoader::newCuesParsed()
void TextTrackLoader::newRegionsParsed()
{
- m_client->newRegionsAvailable(this);
+ m_client.newRegionsAvailable(this);
}
void TextTrackLoader::fileFailedToParse()
« no previous file with comments | « Source/core/loader/TextTrackLoader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698