Roll Skia DEPS to r12012

Roll Skia DEPS to r12012

R=enne@chromium.org, reed@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231886

[robertphillips, 2013-10-29 22:55:35]

control: https://codereview.chromium.org/51643002/

[robertphillips, 2013-10-30 12:44:23]

This roll is failing widely on the BackgroundFilterBlurOffAxis test (linux,
linux_asan, mac, mac_asan) and is failing the following 11 layout tests on Mac
and Linux:

  compositing/geometry/layer-due-to-layer-children.html [ ImageOnlyFailure ]
        small changes to perspective rect edge
  compositing/geometry/vertical-scroll-composited.html [ ImageOnlyFailure ]
        tiny changes to path edge
  compositing/overflow/nested-render-surfaces-with-rotation.html [
ImageOnlyFailure ]
        tiny changes to rotated rect edges
  compositing/perpendicular-layer-sorting.html [ ImageOnlyFailure ]
        tiny changes to perspective rect edges
  compositing/reflections/animation-inside-reflection.html [ ImageOnlyFailure ]
        tiny changes to rotated rect edges
  compositing/reflections/transform-inside-reflection.html [ ImageOnlyFailure ]
        tiny changes to rotated rect edges
  fast/sub-pixel/transformed-iframe-copy-on-scroll.html [ ImageOnlyFailure ]
        imperceptible change to antialiased axis-aligned rect edges
  transforms/3d/point-mapping/3d-point-mapping-deep.html [ ImageOnlyFailure ]
        tiny changes to rotated rect edges
  transforms/3d/point-mapping/3d-point-mapping-origins.html [ ImageOnlyFailure ]
        tiny changes to perspective rect edges
  transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html [
ImageOnlyFailure ]
        tiny changes to perspective rect edges
 
virtual/gpu/compositedscrolling/overflow/nested-render-surfaces-with-rotation.html
[ ImageOnlyFailure ]
        tiny changes to rotated rect edges

The following test, Mac-only:

  compositing/geometry/fixed-position-transform-composited-page-scale-down.html
[ ImageOnlyFailure ]
        small changes to text

The following 6 tests, Linux-only:

  transforms/3d/general/perspective-units.html [ ImageOnlyFailure ]
        tiny changes to perspective rect edges
  virtual/softwarecompositing/geometry/vertical-scroll-composited.html [
ImageOnlyFailure ]
        minor changes to path edges
  virtual/softwarecompositing/huge-layer-rotated.html [ ImageOnlyFailure ]
        imperceptible changes to interior of rotated rect
  virtual/softwarecompositing/lots-of-img-layers-with-opacity.html [
ImageOnlyFailure ]
        imperceptible changes
  virtual/softwarecompositing/lots-of-img-layers.html [ ImageOnlyFailure ]
        imperceptible changes
  virtual/softwarecompositing/tiny-layer-rotated.html [ ImageOnlyFailure ]
        imperceptible changes to interior of rotated rect

So the layout tests look fine but we are still blocked on the 
BackgroundFilterBlurOffAxis failure.

Here are the discrepancies between the roll and control:

linux
   roll:    
            buildrunner_tests
                preamble
            cc_unittests failed 1
                BackgroundFilterBlurOffAxis
   control: 
            gclient hooks failed 

linux_asan
   roll:    
            cc_unittests failed 1
                BackgroundFilterBlurOffAxis
   control: 
            green

linux_chromeos
   roll:    
            buildrunner_tests
                preamble
            ui_unittests failed 3
                Fonts_GetHeight_GetBaseline
                SetFontList
                StringSizeRespectsFontListMetrics
            views_unittests failed 1
                FontPropertySymbol
   control: 
            green

mac
   roll:    
            buildrunner_tests 
                preamble
            cc_unittests failed 1
                BackgroundFilterBlurOffAxis
   control: 
            green

mac_asan
   roll:    
            buildrunner_tests
                preamble
            cc_unittests failed 1
                BackgroundFilterBlurOffAxis
            unit_tests crashed or hung 
            webkit_unit_tests did not complete failed 1
                XMLDeclaration
            nacl_integration 
   control: 
            buildrunner_tests
                preamble
            unit_tests crashed or hung 
            webkit_unit_tests did not complete failed 1
                XMLDeclaration
            nacl_integration 

win
   roll:    
            buildrunner_tests
                preamble
            telemetry_unittests failed 1
                testWaitAction
   control: 
            buildrunner_tests
                preamble
            content_browsertests did not complete failed 5
                CrossSiteOnunloadCookie
                LimitTotal
                PassMessagePortToSharedWorker
                PassMessagePortToSharedWorkerDontWaitForConnect
                WebSocketSharedWorker

linux_layout
   roll:    
            webkit_tests 158 fixable (0 skipped) failed 17
                3d-point-mapping-deep.html 
                3d-point-mapping-origins.html 
                3d-point-mapping-preserve-3d.html 
                animation-inside-reflection.html 
                huge-layer-rotated.html 
                layer-due-to-layer-children.html 
                lots-of-img-layers-with-opacity.html 
                lots-of-img-layers.html 
                nested-render-surfaces-with-rotation.html 
                nested-render-surfaces-with-rotation.html 
                perpendicular-layer-sorting.html 
                perspective-units.html 
                tiny-layer-rotated.html 
                transform-inside-reflection.html 
                transformed-iframe-copy-on-scroll.html 
                vertical-scroll-composited.html 
                vertical-scroll-composited.html 
   control: 
            gclient_revert failed
            update update r231661 failed

linux_layout_rel
   roll:    
            webkit_tests 132 fixable (0 skipped) failed 17
                3d-point-mapping-deep.html 
                3d-point-mapping-origins.html 
                3d-point-mapping-preserve-3d.html 
                animation-inside-reflection.html 
                huge-layer-rotated.html 
                layer-due-to-layer-children.html 
                lots-of-img-layers-with-opacity.html 
                lots-of-img-layers.html 
                nested-render-surfaces-with-rotation.html 
                nested-render-surfaces-with-rotation.html 
                perpendicular-layer-sorting.html 
                perspective-units.html 
                tiny-layer-rotated.html 
                transform-inside-reflection.html 
                transformed-iframe-copy-on-scroll.html 
                vertical-scroll-composited.html 
                vertical-scroll-composited.html 
   control: 
            green

mac_layout
   roll:    
            webkit_tests 705 fixable (0 skipped) failed 12
                3d-point-mapping-deep.html 
                3d-point-mapping-origins.html 
                3d-point-mapping-preserve-3d.html 
                animation-inside-reflection.html 
                fixed-position-transform-composited-page-scale-down.html 
                layer-due-to-layer-children.html 
                nested-render-surfaces-with-rotation.html 
                nested-render-surfaces-with-rotation.html 
                perpendicular-layer-sorting.html 
                transform-inside-reflection.html 
                transformed-iframe-copy-on-scroll.html 
                vertical-scroll-composited.html 
   control: 
            buildrunner_tests
                preamble
            webkit_unit_tests did not complete failed 1
                ToLength

mac_layout_rel
   roll:    
            webkit_tests 690 fixable (0 skipped) failed 12
                3d-point-mapping-deep.html 
                3d-point-mapping-origins.html 
                3d-point-mapping-preserve-3d.html 
                animation-inside-reflection.html 
                fixed-position-transform-composited-page-scale-down.html 
                layer-due-to-layer-children.html 
                nested-render-surfaces-with-rotation.html 
                nested-render-surfaces-with-rotation.html 
                perpendicular-layer-sorting.html 
                transform-inside-reflection.html 
                transformed-iframe-copy-on-scroll.html 
                vertical-scroll-composited.html 
   control: 
            green

[robertphillips, 2013-10-30 12:57:15]

The BackgroundFilterBlurOffAxis failure appears to be a 1 out of 255 pixel diff
at two locations:

LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOffAxis: 
[52689:4359:1029/171357:6398990349640:ERROR:pixel_comparator.cc(40)] Pixel error
at x=17 y=76; actual RGBA=(125,125,125,0); expected RGBA=(126,126,126,0)
[52689:4359:1029/171357:6398991648133:ERROR:pixel_comparator.cc(40)] Pixel error
at x=158 y=100; actual RGBA=(123,123,123,0); expected RGBA=(122,122,122,0)
[52689:4359:1029/171357:6398992067561:ERROR:pixel_comparator.cc(56)] Number of
pixel with an error: 2
../../cc/test/layer_tree_pixel_test.cc:104: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
Actual: false
Expected: true

The CLs in this roll are:
https://code.google.com/p/skia/source/list?num=21&start=12012

These changes are most likely due to:

r12009 Remove SkMatrix44 float conversions without precision loss
(https://codereview.chromium.org/50423004)

[robertphillips, 2013-10-30 13:56:20]

+enne for cc change

[robertphillips, 2013-10-30 14:41:26]

We have green on the mac and linux layout tests (both debug and release) and the
linux_asan bot, so I think this is rollable (modulo getting a cc lgtm).

[reed1, 2013-10-30 14:52:16]

lgtm

[enne (OOO), 2013-10-30 18:42:25]

lgtm

[robertphillips, 2013-10-30 18:44:39]

Committed patchset #4 manually as r231886 (presubmit successful).

[danakj, 2013-10-30 19:04:29]

On 2013/10/30 18:44:39, robertphillips wrote:
> Committed patchset #4 manually as r231886 (presubmit successful).

Looks like thie rebaseline isn't correctly matching the new output?

[danakj, 2013-10-30 19:04:41]

On 2013/10/30 18:44:39, robertphillips wrote:
> Committed patchset #4 manually as r231886 (presubmit successful).

Looks like thie rebaseline isn't correctly matching the new output?

[danakj, 2013-10-30 19:09:13]

On 2013/10/30 19:04:41, danakj wrote:
> On 2013/10/30 18:44:39, robertphillips wrote:
> > Committed patchset #4 manually as r231886 (presubmit successful).
> 
> Looks like thie rebaseline isn't correctly matching the new output?

Works fine after sync. PEBKAC.