Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 50423004: Remove SkMatrix44 float conversions without precision loss (Closed)

Created:
7 years, 1 month ago by enne (OOO)
Modified:
7 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com, epoger
Visibility:
Public.

Description

Remove SkMatrix44 float conversions without precision loss BUG=none Committed: http://code.google.com/p/skia/source/detail?r=12009

Patch Set 1 #

Patch Set 2 : Use SkFloatToMScalar #

Patch Set 3 : Typo #

Patch Set 4 : One more SkMScalarToFloat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M src/utils/SkMatrix44.cpp View 1 2 3 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
Mike, what do you think about this as a potential fix for what you brought ...
7 years, 1 month ago (2013-10-29 17:50:49 UTC) #1
reed1
very clean. lgtm
7 years, 1 month ago (2013-10-29 20:40:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/enne@chromium.org/50423004/90001
7 years, 1 month ago (2013-10-29 20:44:23 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 21:08:53 UTC) #4
Message was sent while issue was closed. 
Change committed as 12009

Powered by Google App Engine
This is Rietveld 408576698