QUIC - Construct crypto_stream_ in QuicClientSession::InitializeSession

QUIC - Construct crypto_stream_ in QuicClientSession::InitializeSession
instread of QuicClientSession's constructor to make it easier for server
side code to do the same.

Call QuicClientSessionBase::InitializeSession() after constructing
QuicCryptoClientStream.

This is done per discussion in interal change: 72671781

The following are the earlier related issues:
  https://codereview.chromium.org/393953009/
  https://codereview.chromium.org/407193002/
  

R=rch@chromium.org

Committed: https://crrev.com/b998b32fe737ccb9cec756f60660dee9b4cacfd8
Cr-Commit-Position: refs/heads/master@{#291812}

[Ryan Hamilton, 2014-08-25 22:05:01]

lgtm

[ramant (doing other things), 2014-08-25 23:31:35]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-25 23:33:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/481103003/1

[commit-bot: I haz the power, 2014-08-26 00:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 00:16:54]

Failed to commit the patch.

[ramant (doing other things), 2014-08-26 00:30:37]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-26 00:34:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/481103003/1

[ramant (doing other things), 2014-08-26 00:36:44]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-08-26 00:37:54]

Committed patchset #1 (1) as 00a8dc5af485a7a773c9d03c4c23da0e24a02331

[wtc, 2014-08-26 18:35:42]

wtc@chromium.org changed reviewers:
+ wtc@chromium.org

[wtc, 2014-08-26 18:35:42]

Patch set 2 LGTM.

https://codereview.chromium.org/481103003/diff/20001/net/quic/quic_client_ses...
File net/quic/quic_client_session.h (right):

https://codereview.chromium.org/481103003/diff/20001/net/quic/quic_client_ses...
net/quic/quic_client_session.h:225: scoped_ptr<HostPortPair> server_host_port_;

It seems that this doesn't need to be a pointer. We just need to remove the
'const':

  HostPortPair server_host_port_;

[ramant (doing other things), 2014-08-27 22:06:46]

Thanks Wan-Teh,
raman

https://codereview.chromium.org/481103003/diff/20001/net/quic/quic_client_ses...
File net/quic/quic_client_session.h (right):

https://codereview.chromium.org/481103003/diff/20001/net/quic/quic_client_ses...
net/quic/quic_client_session.h:225: scoped_ptr<HostPortPair> server_host_port_;
On 2014/08/26 18:35:42, wtc wrote:
> 
> It seems that this doesn't need to be a pointer. We just need to remove the
> 'const':
> 
>   HostPortPair server_host_port_;

Fixed it in CL: https://codereview.chromium.org/511543006

Done.

[commit-bot: I haz the power, 2014-09-10 02:39:25]

Patchset 2 (id:??) landed as
https://crrev.com/b998b32fe737ccb9cec756f60660dee9b4cacfd8
Cr-Commit-Position: refs/heads/master@{#291812}