Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 511543006: QUIC - use HostPortPair instead of scoped_ptr<HostPortPair>. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Hamilton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC - use HostPortPair instead of scoped_ptr<HostPortPair>. R=wtc@chromium.org Committed: https://crrev.com/b77a6a1dffd033fa238751b034b5d136e560eb5d Cr-Commit-Position: refs/heads/master@{#292274}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed wtc's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/quic/quic_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_session.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-08-27 22:05:57 UTC) #1
wtc
Patch set 1 LGTM. Please make the following change. https://codereview.chromium.org/511543006/diff/1/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/511543006/diff/1/net/quic/quic_client_session.cc#newcode167 net/quic/quic_client_session.cc:167: ...
6 years, 3 months ago (2014-08-27 22:15:03 UTC) #2
ramant (doing other things)
thanks Wan-Teh (missed we are getting host_port_pair from server_id). https://codereview.chromium.org/511543006/diff/1/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/511543006/diff/1/net/quic/quic_client_session.cc#newcode167 net/quic/quic_client_session.cc:167: ...
6 years, 3 months ago (2014-08-27 22:24:56 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 3 months ago (2014-08-27 22:25:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/511543006/20001
6 years, 3 months ago (2014-08-27 22:27:29 UTC) #5
wtc
Patch set 2 LGTM.
6 years, 3 months ago (2014-08-27 22:45:02 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 23:40:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as db3dc5325fce5bee800497de2a1e633d063cea4d
6 years, 3 months ago (2014-08-27 23:54:12 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:55:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b77a6a1dffd033fa238751b034b5d136e560eb5d
Cr-Commit-Position: refs/heads/master@{#292274}

Powered by Google App Engine
This is Rietveld 408576698