Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 481053003: Honor x-chrome header on non web triggerable transitions (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Honor x-chrome header on non web triggerable transitions Fixed a regression introduced in cl 488163003. Manual navigation, e.g. typing url or clicking bookmark, is not considered user gesture. Thus with the cl 488163003, chrome will ignore x-chrome-manage-account header on manual navigation to gaia endpoints. We should honor header on both non web triggerable transitions and web triggerable transitions with user gesture. BUG=394869 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/signin/signin_header_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 4 months ago (2014-08-22 19:09:00 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-22 19:28:24 UTC) #2
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-22 19:28:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/481053003/1
6 years, 4 months ago (2014-08-22 19:29:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 20:51:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 21:56:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 291518

Powered by Google App Engine
This is Rietveld 408576698