chrome/browser/signin/signin_header_helper.cc - Issue 481053003: Honor x-chrome header on non web triggerable transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_header_helper.cc

Issue 481053003: Honor x-chrome header on non web triggerable transitions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/signin_header_helper.cc

diff --git a/chrome/browser/signin/signin_header_helper.cc b/chrome/browser/signin/signin_header_helper.cc

index 469b91ad274a3d2c828b4adff68fd607b49c81a6..dd8437549d5890fa0dabb8c4c8fb53d5db9d9c0f 100644

--- a/chrome/browser/signin/signin_header_helper.cc

+++ b/chrome/browser/signin/signin_header_helper.cc

@@ -256,7 +256,9 @@ void ProcessMirrorResponseHeaderIfExists(

const content::ResourceRequestInfo* info =

content::ResourceRequestInfo::ForRequest(request);

- if (!(info && info->IsMainFrame() && info->HasUserGesture()))

+ if (!(info && info->IsMainFrame() &&

+ (info->HasUserGesture() ||

+ !content::PageTransitionIsWebTriggerable(info->GetPageTransition()))))

return;

std::string header_value;

« no previous file with comments | « no previous file | no next file » | no next file with comments »