Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 480823004: Get rid of GetLazyValue and clients. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Get rid of GetLazyValue and clients. This breaks fetching name of the constructor property of "Object"-labeled values in the heap-snapshot-generator until that's handlified and can be moved over to the LookupIterator. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23226

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -178 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M src/ic.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/objects.cc View 3 chunks +20 lines, -25 lines 0 comments Download
M src/property.h View 4 chunks +7 lines, -105 lines 0 comments Download
M src/property.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-19 15:12:48 UTC) #1
aandrey
GetLazyValue() is also used in Function::GetDisplayName() in api.cc +cc yurys on heap-snapshot-generator.cc
6 years, 4 months ago (2014-08-19 15:49:43 UTC) #2
Toon Verwaest
api.cc was already updated in https://codereview.chromium.org/481043002
6 years, 4 months ago (2014-08-19 15:53:27 UTC) #3
Jakob Kummerow
LGTM if Yury is fine with the heap-snapshot-generator change.
6 years, 4 months ago (2014-08-19 16:50:06 UTC) #4
Toon Verwaest
Committed patchset #1 manually as 23226 (presubmit successful).
6 years, 4 months ago (2014-08-20 10:37:34 UTC) #5
yurys
6 years, 4 months ago (2014-08-20 10:56:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698