Get rid of LookupRealNamedProperty and LookupRealNamedPropertyInPrototypes and update clients

Get rid of LookupRealNamedProperty and LookupRealNamedPropertyInPrototypes and update clients

BUG=
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23202

[Toon Verwaest, 2014-08-18 16:44:40]

PTAL

[Jakob Kummerow, 2014-08-19 14:21:22]

lgtm

[Toon Verwaest, 2014-08-19 14:58:49]

Committed patchset #1 manually as 23202 (presubmit successful).

[aandrey, 2014-08-19 16:01:15]

https://codereview.chromium.org/481043002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4058
src/api.cc:4058: i::LookupIterator it(func, property_name,
this var is not used, or does it behave like a scope? (then LookupIteratorScope
would be a better name)

https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4062
src/api.cc:4062: i::JSObject::GetDataProperty(func, property_name);
this should not result in any side effects, like calling getter functions
(that's why GetLazyValue was used). is it still the case?

[Toon Verwaest, 2014-08-19 16:04:49]

https://codereview.chromium.org/481043002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4058
src/api.cc:4058: i::LookupIterator it(func, property_name,
On 2014/08/19 16:01:15, aandrey wrote:
> this var is not used, or does it behave like a scope? (then
LookupIteratorScope
> would be a better name)

I just realized, hence https://codereview.chromium.org/485113003/

https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4062
src/api.cc:4062: i::JSObject::GetDataProperty(func, property_name);
On 2014/08/19 16:01:15, aandrey wrote:
> this should not result in any side effects, like calling getter functions
> (that's why GetLazyValue was used). is it still the case?

Yes, that's what GetDataProperty is for.

[loislo, 2014-08-20 14:09:17]

On 2014/08/19 16:04:49, Toon Verwaest wrote:
> https://codereview.chromium.org/481043002/diff/1/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4058
> src/api.cc:4058: i::LookupIterator it(func, property_name,
> On 2014/08/19 16:01:15, aandrey wrote:
> > this var is not used, or does it behave like a scope? (then
> LookupIteratorScope
> > would be a better name)
> 
> I just realized, hence https://codereview.chromium.org/485113003/
> 
> https://codereview.chromium.org/481043002/diff/1/src/api.cc#newcode4062
> src/api.cc:4062: i::JSObject::GetDataProperty(func, property_name);
> On 2014/08/19 16:01:15, aandrey wrote:
> > this should not result in any side effects, like calling getter functions
> > (that's why GetLazyValue was used). is it still the case?
> 
> Yes, that's what GetDataProperty is for.

REGRESSION: window.localStorage doesn't persist its content after this patch
1) open devtools
2) select sources tab
3) reopen devtools

expected: sources tab is selected

actual: elements tab is selected