Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 480803002: Merge CompositedScrollingForFrames into PreferCompositingToLCDText (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., piman, rune+blink, Ian Vollick, zoltan1
Project:
blink
Visibility:
Public.

Description

Merge CompositedScrollingForFrames into PreferCompositingToLCDText Remove the CompositedScrollingForFrames setting and change any callers to use PreferCompositingToLCDText instead. R=abarth BUG=365851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M LayoutTests/compositing/force-compositing-mode/force-composite-empty.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/no-overflow-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/force-compositing-mode/overflow-iframe-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/iframes/iframe-composited-scrolling.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/iframes/iframe-composited-scrolling-hide-and-show.html View 1 chunk +11 lines, -13 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
6 years, 4 months ago (2014-08-17 22:14:04 UTC) #1
danakj
Depends on https://codereview.chromium.org/480793002/
6 years, 4 months ago (2014-08-17 22:14:11 UTC) #2
abarth-chromium
LGTM
6 years, 4 months ago (2014-08-18 00:35:46 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 15:17:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480803002/1
6 years, 4 months ago (2014-08-18 15:18:29 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 15:21:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180466

Powered by Google App Engine
This is Rietveld 408576698