Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 480803002: Merge CompositedScrollingForFrames into PreferCompositingToLCDText (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/rendering/compositing/CompositingReasonFinder.h" 6 #include "core/rendering/compositing/CompositingReasonFinder.h"
7 7
8 #include "core/CSSPropertyNames.h" 8 #include "core/CSSPropertyNames.h"
9 #include "core/dom/Document.h" 9 #include "core/dom/Document.h"
10 #include "core/frame/FrameView.h" 10 #include "core/frame/FrameView.h"
11 #include "core/frame/Settings.h" 11 #include "core/frame/Settings.h"
12 #include "core/page/Page.h" 12 #include "core/page/Page.h"
13 #include "core/rendering/RenderView.h" 13 #include "core/rendering/RenderView.h"
14 #include "core/rendering/compositing/RenderLayerCompositor.h" 14 #include "core/rendering/compositing/RenderLayerCompositor.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 CompositingReasonFinder::CompositingReasonFinder(RenderView& renderView) 18 CompositingReasonFinder::CompositingReasonFinder(RenderView& renderView)
19 : m_renderView(renderView) 19 : m_renderView(renderView)
20 , m_compositingTriggers(static_cast<CompositingTriggerFlags>(AllCompositingT riggers)) 20 , m_compositingTriggers(static_cast<CompositingTriggerFlags>(AllCompositingT riggers))
21 { 21 {
22 updateTriggers(); 22 updateTriggers();
23 } 23 }
24 24
25 void CompositingReasonFinder::updateTriggers() 25 void CompositingReasonFinder::updateTriggers()
26 { 26 {
27 m_compositingTriggers = 0; 27 m_compositingTriggers = 0;
28 28
29 Settings& settings = m_renderView.document().page()->settings(); 29 Settings& settings = m_renderView.document().page()->settings();
30 if (settings.compositedScrollingForFramesEnabled()) 30 if (settings.preferCompositingToLCDTextEnabled()) {
31 m_compositingTriggers |= ScrollableInnerFrameTrigger; 31 m_compositingTriggers |= ScrollableInnerFrameTrigger;
32 m_compositingTriggers |= ViewportConstrainedPositionedTrigger;
33 }
32 34
33 // We map both these settings to universal overlow scrolling. 35 // We map both these settings to universal overlow scrolling.
34 // FIXME: Replace these settings with a generic compositing setting for High DPI. 36 // FIXME: Replace these settings with a generic compositing setting for High DPI.
35 if (settings.acceleratedCompositingForOverflowScrollEnabled() || settings.co mpositorDrivenAcceleratedScrollingEnabled()) 37 if (settings.acceleratedCompositingForOverflowScrollEnabled() || settings.co mpositorDrivenAcceleratedScrollingEnabled())
36 m_compositingTriggers |= OverflowScrollTrigger; 38 m_compositingTriggers |= OverflowScrollTrigger;
37
38 if (settings.preferCompositingToLCDTextEnabled())
39 m_compositingTriggers |= ViewportConstrainedPositionedTrigger;
40 } 39 }
41 40
42 bool CompositingReasonFinder::hasOverflowScrollTrigger() const 41 bool CompositingReasonFinder::hasOverflowScrollTrigger() const
43 { 42 {
44 return m_compositingTriggers & OverflowScrollTrigger; 43 return m_compositingTriggers & OverflowScrollTrigger;
45 } 44 }
46 45
47 bool CompositingReasonFinder::isMainFrame() const 46 bool CompositingReasonFinder::isMainFrame() const
48 { 47 {
49 // FIXME: LocalFrame::isMainFrame() is probably better. 48 // FIXME: LocalFrame::isMainFrame() is probably better.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 bool CompositingReasonFinder::requiresCompositingForPositionFixed(const RenderLa yer* layer) const 168 bool CompositingReasonFinder::requiresCompositingForPositionFixed(const RenderLa yer* layer) const
170 { 169 {
171 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger)) 170 if (!(m_compositingTriggers & ViewportConstrainedPositionedTrigger))
172 return false; 171 return false;
173 // Don't promote fixed position elements that are descendants of a non-view container, e.g. transformed elements. 172 // Don't promote fixed position elements that are descendants of a non-view container, e.g. transformed elements.
174 // They will stay fixed wrt the container rather than the enclosing frame. 173 // They will stay fixed wrt the container rather than the enclosing frame.
175 return layer->scrollsWithViewport() && m_renderView.frameView()->isScrollabl e(); 174 return layer->scrollsWithViewport() && m_renderView.frameView()->isScrollabl e();
176 } 175 }
177 176
178 } 177 }
OLDNEW
« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698