Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 480713004: Fix the image decode telemetry perf unittest on impl side painting. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, reveman, Vangelis Kokkevis, Alpha Left Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the image decode telemetry perf unittest on impl side painting. This test was enabling a lot of categories that it should not have. When using impl side painting, we can use the trace events from blink.ImageFrameGenerator::decode to measure the time. On legacy compositing, this doesn't exist and we have to fall back to the "timeline.Decode Image" event still. Left FIXMEs to remove this. BUG=405244 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291304

Patch Set 1 #

Patch Set 2 : imagedecode: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M tools/perf/measurements/image_decoding.py View 1 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 4 months ago (2014-08-21 20:54:18 UTC) #1
danakj
This change basically boils down to removing the * and adding the blink category and ...
6 years, 4 months ago (2014-08-21 21:00:52 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-21 21:43:42 UTC) #3
tonyg
lgtm
6 years, 4 months ago (2014-08-21 21:43:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480713004/20001
6 years, 4 months ago (2014-08-21 21:45:45 UTC) #5
danakj
Thanks!
6 years, 4 months ago (2014-08-21 21:46:05 UTC) #6
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-22 01:33:54 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-22 01:34:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480713004/20001
6 years, 4 months ago (2014-08-22 01:34:12 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:36:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291304

Powered by Google App Engine
This is Rietveld 408576698