Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: tools/perf/measurements/image_decoding.py

Issue 480713004: Fix the image decode telemetry perf unittest on impl side painting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: imagedecode: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/image_decoding.py
diff --git a/tools/perf/measurements/image_decoding.py b/tools/perf/measurements/image_decoding.py
index be9dc570e5e4fe516ca479e05c4e16c0546f68db..09ba507310338db42d08256f725d9c3e2b6b009e 100644
--- a/tools/perf/measurements/image_decoding.py
+++ b/tools/perf/measurements/image_decoding.py
@@ -35,15 +35,18 @@ class ImageDecoding(page_test.PageTest):
options = tracing_options.TracingOptions()
options.enable_chrome_trace = True
- # FIXME: bare 'devtools' is for compatibility with older reference versions
- # only and may eventually be removed.
+ # FIXME: Remove the timeline category when impl-side painting is on
+ # everywhere.
category_filter = tracing_category_filter.TracingCategoryFilter(
- 'disabled-by-default-devtools.timeline*')
+ 'disabled-by-default-devtools.timeline')
# FIXME: Remove webkit.console when blink.console lands in chromium and
# the ref builds are updated. crbug.com/386847
+ # FIXME: Remove the devtools.timeline category when impl-side painting is
+ # on everywhere.
categories = [
- 'devtools',
+ 'blink',
+ 'devtools.timeline',
'webkit.console',
'blink.console'
]
@@ -67,7 +70,11 @@ class ImageDecoding(page_test.PageTest):
def _IsDone():
return tab.EvaluateJavaScript('isDone')
- decode_image_events = timeline_model.GetAllEventsOfName('Decode Image')
+ decode_image_events = timeline_model.GetAllEventsOfName(
+ 'ImageFrameGenerator::decode')
+ # FIXME: Remove this when impl-side painting is on everywhere.
+ if not decode_image_events:
+ decode_image_events = timeline_model.GetAllEventsOfName('Decode Image')
# If it is a real image page, then store only the last-minIterations
# decode tasks.
@@ -79,7 +86,7 @@ class ImageDecoding(page_test.PageTest):
decode_image_events = decode_image_events[-min_iterations:]
durations = [d.duration for d in decode_image_events]
- assert durations, 'Failed to find "Decode Image" trace events.'
+ assert durations, 'Failed to find image decode trace events.'
image_decoding_avg = sum(durations) / len(durations)
results.AddValue(scalar.ScalarValue(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698