Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: ui/gfx/win/singleton_hwnd.cc

Issue 480503002: [Win] Battery Status API: use SingletonHwnd for notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added thread checker Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/win/singleton_hwnd.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/win/singleton_hwnd.cc
diff --git a/ui/gfx/win/singleton_hwnd.cc b/ui/gfx/win/singleton_hwnd.cc
index fc4d11f2d5e0d8146d9a3fa5c0f666e2e3c86676..e3587a22d4871603b4b55537883f8f574ea25526 100644
--- a/ui/gfx/win/singleton_hwnd.cc
+++ b/ui/gfx/win/singleton_hwnd.cc
@@ -15,10 +15,12 @@ SingletonHwnd* SingletonHwnd::GetInstance() {
}
void SingletonHwnd::AddObserver(Observer* observer) {
+ DCHECK(thread_checker_.CalledOnValidThread());
observer_list_.AddObserver(observer);
}
void SingletonHwnd::RemoveObserver(Observer* observer) {
+ DCHECK(thread_checker_.CalledOnValidThread());
if (!hwnd())
return;
observer_list_.RemoveObserver(observer);
@@ -37,10 +39,11 @@ BOOL SingletonHwnd::ProcessWindowMessage(HWND window,
}
SingletonHwnd::SingletonHwnd() {
+ DCHECK(thread_checker_.CalledOnValidThread());
if (!base::MessageLoopForUI::IsCurrent()) {
// Creating this window in (e.g.) a renderer inhibits shutdown on
// Windows. See http://crbug.com/230122 and http://crbug.com/236039.
- DLOG(ERROR) << "Cannot create windows on non-UI thread!";
+ DLOG(FATAL) << "Cannot create windows on non-UI thread!";
return;
}
WindowImpl::Init(NULL, Rect());
« no previous file with comments | « ui/gfx/win/singleton_hwnd.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698