Issue 480503002: [Win] Battery Status API: use SingletonHwnd for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480503002: [Win] Battery Status API: use SingletonHwnd for notifications. (Closed)

Created:
6 years, 4 months ago by timvolodine

Modified:
6 years ago

Reviewers:
cpu_(ooo_6.6-7.5), scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Win] Battery Status API: use SingletonHwnd for notifications. Use a singleton message-only window (SingletonHwnd) instead of creating a separate message window for receiving battery notifications. In addition to re-using the window, this simplifies some logic in BatteryStatusManagerObserver. BUG=404139

Patch Set 1 #

Patch Set 2 : added thread checker #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -59 lines)			Patch
M	content/browser/battery_status/battery_status_manager_win.cc	View	1	5 chunks	+43 lines, -58 lines	0 comments	Download
M	ui/gfx/win/singleton_hwnd.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/win/singleton_hwnd.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

Sorry, I missed this. SingletonHwnd has default traits on Singleton<> which seems to mean it ...

6 years, 3 months ago (2014-08-26 19:56:58 UTC) #2

timvolodine

6 years, 3 months ago (2014-09-01 12:09:12 UTC) #5

On 2014/09/01 11:55:57, timvolodine wrote:

Actually SingletonHwnd AddObserver(), RemoveObserver() do not seem to be
thread-safe. Assuming that the current usage of SingletonHwnd is from the UI
thread (but I am not 100% sure), I've added a ThreadChecker for this, probably
better would be to use an explicit BrowserThread::UI check, but gfx does not
seem to link with content.. + also added a DLOG(FATAL) when created on non UI
thread.

After running the tests it appears the SingletonHwnd is actually created on
non-ui threads! (e.g. SysColorChangeObserver and CachedFontRenderParams). This
looks weird: why would we create a dummy singleton hwnd in those cases? Also
this isn't particularly encouraging regarding thread-safety..

Expand Messages | Collapse Messages