Disable UI flags for non-desktop OSes

components/signin/core/common/profile_management_switches.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/common/profile_management_switches.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "build/build_config.h"
 #include "components/signin/core/common/signin_switches.h"
@@ skipping 126 matching lines @@
 bool IsFastUserSwitching() {
   return CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kFastUserSwitching);
 }
 
 bool IsGoogleProfileInfo() {
   return CheckFlag(switches::kGoogleProfileInfo, STATE_NEW_AVATAR_MENU);
 }
 
 bool IsNewAvatarMenu() {
+  // NewAvatarMenu is only available on desktop.
+#if defined(OS_ANDROID) || defined(OS_IOS) || defined(OS_CHROMEOS)
+  return false;
+#else
   return GetProcessState() >= STATE_NEW_AVATAR_MENU;
+#endif
 }
 
 bool IsNewProfileManagement() {
+  // NewProfileManagement is only available on desktop.

[Nikita (slow), 2014/08/15 14:56:13]

That's not correct.

On Chrome OS "new profile management" also works.
Uber tray has "Add account" item when this flag (and account consistency) is
enabled.

Maybe Chrome OS should only rely on "account consistency" flag.

Pavel should know better.

[dzhioev (left Google), 2014/08/15 15:31:33]

I don't know for sure. Chrome OS checks only IsEnableAccountConsistency to
decide whether Mirror UI should be shown or not. It used IsNewProfileManagement
before, but this changed after https://codereview.chromium.org/372033002 where
IsNewProfileManagement was renamed to IsEnableAccountConsistency. Mike, can you
confirm that such behavior is correct?

+#if defined(OS_ANDROID) || defined(OS_IOS) || defined(OS_CHROMEOS)
+  return false;
+#else
   return GetProcessState() >= STATE_NEW_PROFILE_MANAGEMENT;
+#endif
 }
 
 bool IsNewProfileManagementPreviewEnabled() {
   // No promotion to Enable Account Consistency.
   return false;
 }
 
 void EnableNewAvatarMenuForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitch(switches::kEnableNewAvatarMenu);
   DCHECK(!command_line->HasSwitch(switches::kDisableNewAvatarMenu));
 }
 
 void DisableNewAvatarMenuForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitch(switches::kDisableNewAvatarMenu);
   DCHECK(!command_line->HasSwitch(switches::kEnableNewAvatarMenu));
 }
 
 void EnableNewProfileManagementForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitch(switches::kEnableNewProfileManagement);
   DCHECK(!command_line->HasSwitch(switches::kDisableNewProfileManagement));
 }
 
 void EnableAccountConsistencyForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitch(switches::kEnableAccountConsistency);
   DCHECK(!command_line->HasSwitch(switches::kDisableAccountConsistency));
 }
 
 }  // namespace switches