Change semantics of newProfileManagement() to accountConsistency()

Change semantics from newProfileManagement() to accountConsistency().

Account Consistency should enable the Accounts Reconcilor, the multi-accounts UI in the user menu, and inform GAIA to show Manager Accounts not Add Account & Sign Out. This CL also should disable the promo card that leads a user from NewProfileManager to EnableAccountConsistency.

Please note the first message of the CL contains a full list of all references to IsNewProfileManagement and why each was or was not included in this change.

BUG=391497
TEST=Setting the AccountConsistency flag should control all of (and
only) the synchronization of the token service and the cookie jar. All
Mirror-UI should be behind newAvatarMenu and NewProfileManagement.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285253

[Mike Lerman, 2014-07-07 20:22:00]

Following is a list of all references, and why I did/did not change each:


Skipping:
profile_management_switches
about_signin_internals
(as these are about the flags themselves and have no semantics about application
throughout the app)


src/chrome/browser/browser_process_impl.cc        - NOT CHANGED (UI related)   
    244 if (switches::IsNewProfileManagement())

src/chrome/browser/chrome_content_browser_client.cc  - CHANGED
    889 if (switches::IsNewProfileManagement())

src/chrome/browser/chromeos/profiles/profile_list_chromeos.cc   - NOT CHANGED
(UI related)
     55 if (!switches::IsNewProfileManagement() && !icon.IsEmpty()) {

src/chrome/browser/extensions/api/principals_private/principals_private_api.cc 
- CHANGED (part of x-connected-header logic)
     18 if (!switches::IsNewProfileManagement()) {

src/chrome/browser/extensions/signin/gaia_auth_extension_loader.cc  - CHANGED
(part of x-connected-header logic)
     61 (switches::IsNewProfileManagement() &&

src/chrome/browser/profiles/avatar_menu.cc   - NOT CHANGED (UI related)
    122 if (switches::IsNewProfileManagement()) {

src/chrome/browser/profiles/profile_info_cache.cc   - NOT CHANGED (UI related)
    725 if (switches::IsNewProfileManagement()) {
    906 if (switches::IsNewProfileManagement())

src/chrome/browser/profiles/profile_manager.cc   - NOT CHANGED (UI related)
    766 profile_name = switches::IsNewProfileManagement() ?

src/chrome/browser/signin/chrome_signin_client.cc   - CHANGED (part of
cookie/token sync)
    145 !switches::IsNewProfileManagement();
    173 if (switches::IsNewProfileManagement())

src/chrome/browser/signin/signin_header_helper.cc  - CHANGED (part of
x-connected-header logic)
    209 bool is_new_profile_management = switches::IsNewProfileManagement();
    262 DCHECK(switches::IsNewProfileManagement() &&
!io_data->IsOffTheRecord());

src/chrome/browser/signin/signin_promo.cc   - NOT CHANGED (UI related)
    246 signin::Source source = switches::IsNewProfileManagement() ?
    251 switches::IsNewProfileManagement() /* is_constrained */);

src/chrome/browser/signin/signin_tracker_factory.cc   - CHANGED (the account
reconcilor should always be started, will run as no-op depending on flags)
     22 if (!switches::IsEnableWebBasedSignin() &&
switches::IsNewProfileManagement())

src/chrome/browser/ui/ash/chrome_shell_delegate.cc  - CHANGED (controls ChromeOS
multiAccount awareness)
     91 return switches::IsNewProfileManagement();

src/chrome/browser/ui/browser_command_controller_unittest.cc   - NOT CHANGED
(tests about UI)
    178 EXPECT_FALSE(switches::IsNewProfileManagement());
    290 EXPECT_FALSE(switches::IsNewProfileManagement());

src/chrome/browser/ui/startup/startup_browser_creator.cc  - NOT CHANGED (related
to UI and guest mode)
    622 if (switches::IsNewProfileManagement()) {
    663 if (switches::IsNewProfileManagement() &&
    679 if (!switches::IsNewProfileManagement() &&

src/chrome/browser/ui/toolbar/wrench_menu_model.cc  - NOT CHANGED (UI related)
    321 (!switches::IsNewProfileManagement() && command_id == IDC_SHOW_SIGNIN);
    352 DCHECK(!switches::IsNewProfileManagement());
    375 DCHECK(!switches::IsNewProfileManagement());
    401 if (!switches::IsNewProfileManagement() && command_id ==
IDC_SHOW_SIGNIN) {
    706 if (!switches::IsNewProfileManagement()) {

src/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc  - NOT
CHANGED (UI related)
     50 !switches::IsNewProfileManagement())

src/chrome/browser/ui/views/profiles/new_avatar_menu_button_browsertest.cc  -
NOT CHANGED (UI related)
     51 DCHECK(switches::IsNewProfileManagement());

src/chrome/browser/ui/views/profiles/profile_chooser_view.cc  - NOT CHANGED, UI
related and/or will be reviewed once we know more about M38 mocks
    697 if (switches::IsNewProfileManagement())
    827 bool is_new_profile_management = switches::IsNewProfileManagement();
   1111 if (switches::IsNewProfileManagement()) {
   1187 if (!switches::IsNewProfileManagement())

src/chrome/browser/ui/webui/signin/user_manager_ui_browsertest.cc  - NOT
CHANGED, UI related
 (1 occurrence)
     27 DCHECK(switches::IsNewProfileManagement());

src/chrome/renderer/chrome_content_renderer_client.cc  - CHANGED (part of
x-connected-header logic)
 (1 occurrence)
    319 if (switches::IsNewProfileManagement())

src/components/signin/core/browser/account_reconcilor.cc  - CHANGED
 (5 occurrences)
    363 if (!switches::IsNewProfileManagement()) {
    384 if (!switches::IsNewProfileManagement())
    406 if (!switches::IsNewProfileManagement()) {
    420 if (!switches::IsNewProfileManagement())
    766 if (!switches::IsNewProfileManagement())

[Mike Lerman, 2014-07-07 20:23:32]

Hi Hui,

Can you review before I send out for owners reviews? Thanks!

[guohui, 2014-07-07 21:06:57]

lgtm

For CrOS related changes in
chrome/browser/extensions/signin/gaia_auth_extension_loader.cc and
chrome/renderer/chrome_content_renderer_client.cc，

add nkostylev@ to confirm.

https://codereview.chromium.org/372033002/diff/1/chrome/browser/signin/signin...
File chrome/browser/signin/signin_tracker_factory.cc (right):

https://codereview.chromium.org/372033002/diff/1/chrome/browser/signin/signin...
chrome/browser/signin/signin_tracker_factory.cc:22: if
(!switches::IsEnableWebBasedSignin())
so we want to always create an account reconcilor unless web signin is enabled?
why?

[Nikita (slow), 2014-07-08 09:26:42]

lgtm

cc:dzhioev@

[Mike Lerman, 2014-07-08 12:30:48]

https://codereview.chromium.org/372033002/diff/1/chrome/browser/signin/signin...
File chrome/browser/signin/signin_tracker_factory.cc (right):

https://codereview.chromium.org/372033002/diff/1/chrome/browser/signin/signin...
chrome/browser/signin/signin_tracker_factory.cc:22: if
(!switches::IsEnableWebBasedSignin())
On 2014/07/07 21:06:57, guohui wrote:
> so we want to always create an account reconcilor unless web signin is
enabled?
> why?

I removed the check for the NewProfileManagement flag because that is now done
within the AccountReconcilor. 
I didn't touch WebBasedSignin because I'm not aware of anything which would
change the need for it to be here.

[Mike Lerman, 2014-07-08 12:33:15]

Adding reviewers:

Drew - c/b/signin and components/signin
Scott - c/renderer and c/b/ui/ash

Please note the complete listing in the first message of the CL.

Thanks!

[Andrew T Wilson (Slow), 2014-07-08 13:15:51]

lgtm

[sky, 2014-07-09 20:24:06]

LGTM - IsEnableAccountConsistency is a bit confusing as a name, in so far as the
grammar is a bit off. IsAccountConsistencyEnabled() would be much better.

[Mike Lerman, 2014-07-21 15:16:22]

Hi Hui,

I've added the ProfileChooser to the scope of this CL. This CL should now move
everything required to EnableAccountConsistency. Can you take a look? Thanks!

[guohui, 2014-07-22 17:14:04]

On 2014/07/21 15:16:22, Mike Lerman wrote:
> Hi Hui,
> 
> I've added the ProfileChooser to the scope of this CL. This CL should now move
> everything required to EnableAccountConsistency. Can you take a look? Thanks!

still lgtm.

[Mike Lerman, 2014-07-22 19:32:50]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-07-22 19:33:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/372033002/120001

[commit-bot: I haz the power, 2014-07-22 22:47:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 23:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 23:37:06]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[noms (inactive), 2014-07-23 15:17:49]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-07-23 15:19:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/372033002/120001

[commit-bot: I haz the power, 2014-07-23 18:01:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 18:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 18:43:32]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[Mike Lerman, 2014-07-23 19:21:21]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:21:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/372033002/120001

[Mike Lerman, 2014-07-23 20:57:22]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-07-23 20:57:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/372033002/140001

[commit-bot: I haz the power, 2014-07-24 01:35:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-24 03:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 03:25:47]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[Mike Lerman, 2014-07-24 12:40:47]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-07-24 12:42:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/372033002/160001

[commit-bot: I haz the power, 2014-07-24 14:31:03]

Change committed as 285253