Issue 48042: A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookma...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48042: A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookma... (Closed)

Created:
11 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookmark s.html' file. Update the unit test to match the change in bookmark_html_writer.cc The initial CL got reverted because the unittest failed. This CL changes the unittest. BUG=6957 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12426

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_html_writer.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/bookmarks/bookmark_html_writer_unittest.cc	View	1	2 chunks	+8 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 9 months ago (2009-03-24 20:11:11 UTC) #2

LGTM

http://codereview.chromium.org/48042/diff/2001/3001
File chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (right):

http://codereview.chromium.org/48042/diff/2001/3001#newcode115
Line 115: const wchar_t* kBookmarkBarFolderName = L"Bookmarks bar";
All unit tests are run in en-US (see chrome_test_suite.h).

Expand Messages | Collapse Messages