Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc

Issue 48042: A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookma... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_html_writer_unittest.cc
===================================================================
--- chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (revision 12288)
+++ chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (working copy)
@@ -60,7 +60,7 @@
// way of bookmark_html_writer, then using the importer to read it back in.
TEST_F(BookmarkHTMLWriterTest, Test) {
// Populate the BookmarkModel. This creates the following bookmark structure:
- // Bookmark Bar
+ // Bookmarks bar
// F1
// url1
// F2
@@ -110,12 +110,16 @@
// Verify we got back what we wrote.
ASSERT_EQ(6U, parsed_bookmarks.size());
+ // TODO(jungshik): This test will fail if run in a non-en-US locale.
+ // Hardcode the value of IDS_BOOKMARK_BAR_FOLDER_NAME in en-US locale.
+ const wchar_t* kBookmarkBarFolderName = L"Bookmarks bar";
sky 2009/03/24 20:11:11 All unit tests are run in en-US (see chrome_test_s
AssertBookmarkEntryEquals(parsed_bookmarks[0], false, url1, url1_title, t1,
- L"Bookmark Bar", f1_title, std::wstring());
+ kBookmarkBarFolderName, f1_title, std::wstring());
AssertBookmarkEntryEquals(parsed_bookmarks[1], false, url2, url2_title, t2,
- L"Bookmark Bar", f1_title, f2_title);
+ kBookmarkBarFolderName, f1_title, f2_title);
AssertBookmarkEntryEquals(parsed_bookmarks[2], false, url3, url3_title, t3,
- L"Bookmark Bar", std::wstring(), std::wstring());
+ kBookmarkBarFolderName, std::wstring(),
+ std::wstring());
AssertBookmarkEntryEquals(parsed_bookmarks[3], false, url1, url1_title, t1,
std::wstring(), std::wstring(), std::wstring());
AssertBookmarkEntryEquals(parsed_bookmarks[4], false, url2, url2_title, t2,
« no previous file with comments | « chrome/browser/bookmarks/bookmark_html_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698