Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 480173004: Fix flaky CastChannelAPI.TestOpenError test (Closed)

Created:
6 years, 4 months ago by mark a. foltz
Modified:
6 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, extensions-reviews_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove ResultCatcher since test doesn't output any result, just succeeds or fails. BUG=393969 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291309

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js View 2 chunks +0 lines, -2 lines 1 comment Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mark a. foltz
6 years, 4 months ago (2014-08-21 19:20:10 UTC) #1
Wez
LGTM assuming that my assumption that the test will fail if chrome.test.succeed() isn't reached is ...
6 years, 4 months ago (2014-08-21 22:28:54 UTC) #2
mark a. foltz
On 2014/08/21 22:28:54, Wez wrote: > LGTM assuming that my assumption that the test will ...
6 years, 4 months ago (2014-08-21 23:06:51 UTC) #3
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 4 months ago (2014-08-21 23:07:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/480173004/1
6 years, 4 months ago (2014-08-21 23:09:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:15:04 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:47:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 291309

Powered by Google App Engine
This is Rietveld 408576698