chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js - Issue 480173004: Fix flaky CastChannelAPI.TestOpenError test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

Issue 480173004: Fix flaky CastChannelAPI.TestOpenError test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

diff --git a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

index 238570c8ad0dbbde0ee01f81b5f33242fc8113b0..1cb7e4bacf31f6b0fe0331ecf0a74f41397af748 100644

--- a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

+++ b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

@@ -9,7 +9,6 @@ var onClose = function(channel) {

chrome.test.assertLastError('Unknown error.');

assertClosedChannelWithError(channel, 'connect_error');

chrome.test.succeed();

- chrome.test.notifyPass();

Wez 2014/08/21 22:28:54 Lazycodereview, what's the distinction between suc

}

var onError = function(channel, error) {

@@ -30,7 +29,6 @@ var onOpen = function(channel) {

var maybeClose = function(channel) {

if (errorEvent && openCallback) {

- console.log("closing " + JSON.toString(channel));

chrome.cast.channel.close(channel, onClose);

}

};

« no previous file with comments | « no previous file | extensions/browser/api/cast_channel/cast_channel_apitest.cc » ('j') | no next file with comments »