Only show the checkbox for all urls when the switch is on

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index b938f65bfd7c2620f1de9a0964c26101684b7c92..856a6c8adc25ab318dd4a06847258cf046c35242 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -289,9 +289,10 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
   // - The extension has access to enough urls that we can't just let it run
   //   on those specified in the permissions.
   bool wants_all_urls =

[not at google - send to devlin, 2014/08/18 17:57:37]

This is becoming an increasingly misleading variable name. It would be better if
this code did the interpretation of the data, not the WebUI, so a name like
showAllowOnAllWebsitesOption or whatever.

-      extension->permissions_data()->HasWithheldImpliedAllHosts() ||
-      util::AllowedScriptingOnAllUrls(extension->id(),
-                                      extension_service_->GetBrowserContext());
+      (extension->permissions_data()->HasWithheldImpliedAllHosts() ||
+       util::AllowedScriptingOnAllUrls(

[not at google - send to devlin, 2014/08/18 17:57:37]

I think the problem is with AllowedScriptingOnAllUrls, which checks the
preference even if the feature is disabled.

+           extension->id(), extension_service_->GetBrowserContext())) &&
+      FeatureSwitch::scripts_require_action()->IsEnabled();
   extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
   extension_data->SetBoolean(
       "allowAllUrls",