Only show the checkbox for all urls when the switch is on

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_window.h"
 #include "apps/app_window_registry.h"
 #include "apps/saved_files_service.h"
@@ skipping 270 matching lines @@
       dependent_entry->SetString("name", (*i)->name());
       dependents_list->Append(dependent_entry);
     }
   }
   extension_data->Set("dependentExtensions", dependents_list);
 
   // Extensions only want all URL access if:
   // - The feature is enabled.
   // - The extension has access to enough urls that we can't just let it run
   //   on those specified in the permissions.
   bool wants_all_urls =

[not at google - send to devlin, 2014/08/18 17:57:37]

This is becoming an increasingly misleading variable name. It would be better if
this code did the interpretation of the data, not the WebUI, so a name like
showAllowOnAllWebsitesOption or whatever.

-      extension->permissions_data()->HasWithheldImpliedAllHosts() ||
-      util::AllowedScriptingOnAllUrls(extension->id(),
-                                      extension_service_->GetBrowserContext());
+      (extension->permissions_data()->HasWithheldImpliedAllHosts() ||
+       util::AllowedScriptingOnAllUrls(

[not at google - send to devlin, 2014/08/18 17:57:37]

I think the problem is with AllowedScriptingOnAllUrls, which checks the
preference even if the feature is disabled.

+           extension->id(), extension_service_->GetBrowserContext())) &&
+      FeatureSwitch::scripts_require_action()->IsEnabled();
   extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
   extension_data->SetBoolean(
       "allowAllUrls",
       util::AllowedScriptingOnAllUrls(
           extension->id(),
           extension_service_->GetBrowserContext()));
 
   base::string16 location_text;
   if (Manifest::IsPolicyLocation(extension->location())) {
     location_text = l10n_util::GetStringUTF16(
@@ skipping 1097 matching lines @@
     extension_service_->EnableExtension(extension_id);
   } else {
     ExtensionErrorReporter::GetInstance()->ReportError(
         base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
         true);  // Be noisy.
   }
   requirements_checker_.reset();
 }
 
 }  // namespace extensions