Issue 480133002: Only show the checkbox for all urls when the switch is on

Issue 480133002: Only show the checkbox for all urls when the switch is on (Closed)

Created:
6 years, 4 months ago by Devlin

Modified:
6 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Only show the checkbox for all urls when the switch is on BUG=402958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290372

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -15 lines)			Patch
M	chrome/browser/extensions/extension_util.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_util.cc	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/permissions_updater.cc	View	1	2 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

https://codereview.chromium.org/480133002/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/480133002/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode291 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:291: bool wants_all_urls = This is becoming an increasingly misleading ...

6 years, 4 months ago (2014-08-18 17:57:37 UTC) #2

Devlin

On 2014/08/18 17:57:37, kalman wrote: > https://codereview.chromium.org/480133002/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc > File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): > > https://codereview.chromium.org/480133002/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode291 > ...

6 years, 4 months ago (2014-08-18 19:46:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/480133002/40001

6 years, 4 months ago (2014-08-18 20:05:11 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-18 22:04:03 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (40001) as 290372

Expand Messages | Collapse Messages