Port visitedlink tests to Linux. Also make them pass on Linux, which

Port visitedlink tests to Linux. Also make them pass on Linux, which
may fix the attached bug.

The problem was that the debug check was in wrong place (too early, before
every member was initialized), so it failed in the test.

BUG=8710
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11734

[Paweł Hajdan Jr., 2009-03-16 11:55:46]

Please review:

jeremy: visitedlink changes
avi: shared memory changes

[jeremy, 2009-03-16 12:01:35]

Thanks for fixing this, nice work!

http://codereview.chromium.org/48005/diff/1/2
File base/shared_memory.h (right):

http://codereview.chromium.org/48005/diff/1/2#newcode61
Line 61: static SharedMemoryHandle GetInvalidHandle();
IMHO calling this something like NULLHandle() and adding a short comment here
would make things a little clearer.

[Dean McNamee, 2009-03-16 12:02:38]

Drive by.  I would make sure that Brett looks at the visited links related
changes.

http://codereview.chromium.org/48005/diff/1/6
File chrome/browser/visitedlink_unittest.cc (right):

http://codereview.chromium.org/48005/diff/1/6#newcode39
Line 39: base::SharedMemoryHandle new_handle =
base::SharedMemory::GetInvalidHandle();
80 cols

http://codereview.chromium.org/48005/diff/1/6#newcode106
Line 106: base::SharedMemoryHandle new_handle =
base::SharedMemory::GetInvalidHandle();
80 cols

http://codereview.chromium.org/48005/diff/1/6#newcode242
Line 242: base::SharedMemoryHandle new_handle =
base::SharedMemory::GetInvalidHandle();
80 cols

[Avi (use Gerrit), 2009-03-16 14:33:02]

LG

http://codereview.chromium.org/48005/diff/1/2
File base/shared_memory.h (right):

http://codereview.chromium.org/48005/diff/1/2#newcode61
Line 61: static SharedMemoryHandle GetInvalidHandle();
On 2009/03/16 12:01:35, jeremy wrote:
> IMHO calling this something like NULLHandle() and adding a short comment here
> would make things a little clearer.

Definitely rename this. The current name implies side effects.

[Paweł Hajdan Jr., 2009-03-16 15:15:52]

On 2009/03/16 12:01:35, jeremy wrote:
> http://codereview.chromium.org/48005/diff/1/2#newcode61
> Line 61: static SharedMemoryHandle GetInvalidHandle();
> IMHO calling this something like NULLHandle() and adding a short comment here
> would make things a little clearer.

Updated. Can you take a look?

[Paweł Hajdan Jr., 2009-03-16 15:19:06]

+brettw

Please take a look at my changes in visitedlink code.

[brettw, 2009-03-16 16:16:11]

Visited link changes LGTM. It's surprising nobody has noticed this problem
before.