Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: chrome/browser/visitedlink_master.cc

Issue 48005: Port visitedlink tests to Linux. Also make them pass on Linux, which (Closed)
Patch Set: GetInvalidHandle -> NULLHandle Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/shared_memory_win.cc ('k') | chrome/browser/visitedlink_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/visitedlink_master.cc
diff --git a/chrome/browser/visitedlink_master.cc b/chrome/browser/visitedlink_master.cc
index e45c059a0730bcb0efb5e169ac83ff7793f638e2..09a3beeb2f11fa567fcd7483ec7f1641a7bcec14 100644
--- a/chrome/browser/visitedlink_master.cc
+++ b/chrome/browser/visitedlink_master.cc
@@ -582,6 +582,10 @@ bool VisitedLinkMaster::InitFromFile() {
}
used_items_ = used_count;
+#ifndef NDEBUG
+ DebugValidate();
+#endif
+
file_ = file_closer.release();
return true;
}
@@ -597,6 +601,10 @@ bool VisitedLinkMaster::InitFromScratch(bool suppress_rebuild) {
if (!CreateURLTable(table_size, true))
return false;
+#ifndef NDEBUG
+ DebugValidate();
+#endif
+
if (suppress_rebuild) {
// When we disallow rebuilds (normally just unit tests), just use the
// current empty table.
@@ -713,10 +721,6 @@ bool VisitedLinkMaster::CreateURLTable(int32 num_entries, bool init_to_empty) {
hash_table_ = reinterpret_cast<Fingerprint*>(
static_cast<char*>(shared_memory_->memory()) + sizeof(SharedHeader));
-#ifndef NDEBUG
- DebugValidate();
-#endif
-
return true;
}
@@ -731,6 +735,11 @@ bool VisitedLinkMaster::BeginReplaceURLTable(int32 num_entries) {
table_length_ = old_table_length;
return false;
}
+
+#ifndef NDEBUG
+ DebugValidate();
+#endif
+
return true;
}
« no previous file with comments | « base/shared_memory_win.cc ('k') | chrome/browser/visitedlink_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698