Issue 48003002: IDL compiler: remove blank line for void methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48003002: IDL compiler: remove blank line for void methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)

Modified:
7 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: remove blank line for void methods Void methods have a gratuitous blank line. This removes it; it makes the Perl CG a bit more complex (one line), but will make the Python simpler, b/c we will already check for void in the template. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160696

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -106 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/bindings/templates/methods.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8SupportTestInterface.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestActiveDOMObject.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomAccessors.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View		4 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestMediaQueryListListener.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View		77 chunks	+0 lines, -84 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View		6 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/48003002/40001

7 years, 1 month ago (2013-10-28 04:22:31 UTC) #3

Message was sent while issue was closed.

Change committed as 160696

Expand Messages | Collapse Messages