Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 48003002: IDL compiler: remove blank line for void methods (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)
Modified:
7 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: remove blank line for void methods Void methods have a gratuitous blank line. This removes it; it makes the Perl CG a bit more complex (one line), but will make the Python simpler, b/c we will already check for void in the template. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160696

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -106 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +3 lines, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 77 chunks +0 lines, -84 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 6 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
7 years, 1 month ago (2013-10-28 04:04:36 UTC) #1
haraken
LGTM.
7 years, 1 month ago (2013-10-28 04:06:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/48003002/40001
7 years, 1 month ago (2013-10-28 04:22:31 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 05:23:49 UTC) #4
Message was sent while issue was closed.
Change committed as 160696

Powered by Google App Engine
This is Rietveld 408576698