Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 48003002: IDL compiler: remove blank line for void methods (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 5172 matching lines...) Expand 10 before | Expand all | Expand 10 after
5183 $return .= ".release()" if ($returnIsRef); 5183 $return .= ".release()" if ($returnIsRef);
5184 5184
5185 my $nativeValue; 5185 my $nativeValue;
5186 # FIXME: Update for all ScriptWrappables. 5186 # FIXME: Update for all ScriptWrappables.
5187 if (IsDOMNodeType($interfaceName)) { 5187 if (IsDOMNodeType($interfaceName)) {
5188 $nativeValue = NativeToJSValue($function->type, $function->extendedAttri butes, $return, $indent, "", "args.Holder()", "args.GetIsolate()", "args", "imp" , $forMainWorldSuffix, "return"); 5188 $nativeValue = NativeToJSValue($function->type, $function->extendedAttri butes, $return, $indent, "", "args.Holder()", "args.GetIsolate()", "args", "imp" , $forMainWorldSuffix, "return");
5189 } else { 5189 } else {
5190 $nativeValue = NativeToJSValue($function->type, $function->extendedAttri butes, $return, $indent, "", "args.Holder()", "args.GetIsolate()", "args", 0, $f orMainWorldSuffix, "return"); 5190 $nativeValue = NativeToJSValue($function->type, $function->extendedAttri butes, $return, $indent, "", "args.Holder()", "args.GetIsolate()", "args", 0, $f orMainWorldSuffix, "return");
5191 } 5191 }
5192 5192
5193 $code .= $nativeValue . "\n"; 5193 if ($nativeValue) { # Skip blank line for void return type
5194 $code .= $nativeValue . "\n";
5195 }
5194 $code .= $indent . "return;\n"; 5196 $code .= $indent . "return;\n";
5195 5197
5196 return $code; 5198 return $code;
5197 } 5199 }
5198 5200
5199 sub GetNativeType 5201 sub GetNativeType
5200 { 5202 {
5201 my $type = shift; 5203 my $type = shift;
5202 my $extendedAttributes = shift; 5204 my $extendedAttributes = shift;
5203 my $isParameter = shift; 5205 my $isParameter = shift;
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
6233 my $interface = shift; 6235 my $interface = shift;
6234 6236
6235 return 1 if $interface->extendedAttributes->{"CustomToV8"}; 6237 return 1 if $interface->extendedAttributes->{"CustomToV8"};
6236 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"}; 6238 return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
6237 return 1 if InheritsInterface($interface, "Document"); 6239 return 1 if InheritsInterface($interface, "Document");
6238 6240
6239 return 0; 6241 return 0;
6240 } 6242 }
6241 6243
6242 1; 6244 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698