Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: media/video/capture/mac/video_capture_device_qtkit_mac.mm

Issue 480023002: Mac Video Capture: Change an ErrorMessage to LogMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tommi@s comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/mac/video_capture_device_qtkit_mac.mm
diff --git a/media/video/capture/mac/video_capture_device_qtkit_mac.mm b/media/video/capture/mac/video_capture_device_qtkit_mac.mm
index 7f4a853c63a9bde6d9b260a720a947d143f68cbc..86d4e82d71ac2933e44a0954db702558e663120f 100644
--- a/media/video/capture/mac/video_capture_device_qtkit_mac.mm
+++ b/media/video/capture/mac/video_capture_device_qtkit_mac.mm
@@ -140,7 +140,9 @@
} else {
// Remove the previously set capture device.
if (!captureDeviceInput_) {
- [self sendErrorString:[NSString
+ // Being here means stopping a device that never started OK in the first
+ // place, log it.
+ [self sendLogString:[NSString
stringWithUTF8String:"No video capture device set, on removal."]];
return YES;
}
@@ -345,4 +347,12 @@
[lock_ unlock];
}
+- (void)sendLogString:(NSString*)message {
+ DVLOG(1) << [message UTF8String];
+ [lock_ lock];
+ if (frameReceiver_)
+ frameReceiver_->LogMessage([message UTF8String]);
+ [lock_ unlock];
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698