media/video/capture/mac/video_capture_device_mac.h - Issue 480023002: Mac Video Capture: Change an ErrorMessage to LogMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/mac/video_capture_device_mac.h

Issue 480023002: Mac Video Capture: Change an ErrorMessage to LogMessage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tommi@s comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/mac/video_capture_device_mac.h

diff --git a/media/video/capture/mac/video_capture_device_mac.h b/media/video/capture/mac/video_capture_device_mac.h

index 60da1396d5f28575459fb40da90e818fd5b2d17f..1e23c53bb0c4fe0f19700f6fea4436c0b76a745b 100644

--- a/media/video/capture/mac/video_capture_device_mac.h

+++ b/media/video/capture/mac/video_capture_device_mac.h

@@ -73,11 +73,13 @@ class VideoCaptureDeviceMac : public VideoCaptureDevice {

int aspect_numerator,

int aspect_denominator);

+ // Forwarder to VideoCaptureDevice::Client::OnError().

void ReceiveError(const std::string& reason);

+ // Forwarder to VideoCaptureDevice::Client::OnLog().

Henrik Grunell 2014/08/18 12:05:43 Nit: empty line before comment.

mcasas 2014/08/18 12:26:41 Done.

+ void LogMessage(const std::string& message);

private:

void SetErrorState(const std::string& reason);

- void LogMessage(const std::string& message);

bool UpdateCaptureResolution();

// Flag indicating the internal state.

« no previous file with comments | « no previous file | media/video/capture/mac/video_capture_device_qtkit_mac.mm » ('j') | no next file with comments »