Mac Video Capture: Change an ErrorMessage to LogMessage

Mac Video Capture: Change an ErrorMessage to LogMessage

A situation in which we're trying to stop capturing from a device
that has never been initialised properly ends up in
-sendErrorMessage:, but that in turn will trigger VideoCaptureController
-> VideoCaptureHost -> MediaStreamManager, that would try to tear
down the whole capture infrastructure, and that would end up in
the same point that caused the -sendErrorMessage.

In this case, Log instead of sending an Error.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290250

[mcasas, 2014-08-18 09:44:03]

grunell@: PTAL
tommi@: OWNERS RS / PTAL.

[tommi (sloooow) - chröme, 2014-08-18 09:50:06]

https://codereview.chromium.org/480023002/diff/1/media/video/capture/mac/vide...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_mac.h:77: void LogMessage(const
std::string& message);
This requires some documentation now that it's public.  LogMessage is also
pretty generic.  What is a message in this context and where is this being
logged to?  Should this only be used for errors? Is it for debugging? If not,
what? etc

[Henrik Grunell, 2014-08-18 09:52:00]

Is the bug number really correct? Does this send UMS stats?

[Henrik Grunell, 2014-08-18 09:52:08]

On 2014/08/18 09:52:00, Henrik Grunell wrote:
> Is the bug number really correct? Does this send UMS stats?

UMA

[mcasas, 2014-08-18 10:47:31]

tommi@ PTAL. Thought it would suffice to point to the
place where the sendErrorMessage and sendLogMessage
trampoline to.

grunell@ PTAL

https://codereview.chromium.org/480023002/diff/1/media/video/capture/mac/vide...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/1/media/video/capture/mac/vide...
media/video/capture/mac/video_capture_device_mac.h:77: void LogMessage(const
std::string& message);
On 2014/08/18 09:50:06, tommi wrote:
> This requires some documentation now that it's public.  LogMessage is also
> pretty generic.  What is a message in this context and where is this being
> logged to?  Should this only be used for errors? Is it for debugging? If not,
> what? etc

Done.

[tommi (sloooow) - chröme, 2014-08-18 10:54:45]

https://codereview.chromium.org/480023002/diff/40001/media/video/capture/mac/...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/40001/media/video/capture/mac/...
media/video/capture/mac/video_capture_device_mac.h:78: // Forwarder to
VideoCaptureDevice::OnLog().
actually, this forwards to the client, not the capture device.
same for OnError?

[mcasas, 2014-08-18 11:52:59]

PTAL

https://codereview.chromium.org/480023002/diff/40001/media/video/capture/mac/...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/40001/media/video/capture/mac/...
media/video/capture/mac/video_capture_device_mac.h:78: // Forwarder to
VideoCaptureDevice::OnLog().
On 2014/08/18 10:54:45, tommi wrote:
> actually, this forwards to the client, not the capture device.
> same for OnError?

Done.

[tommi (sloooow) - chröme, 2014-08-18 12:01:20]

lgtm

[Henrik Grunell, 2014-08-18 12:05:43]

Please remove the BUG= line or file a bug.

LGTM with nit fixed.

https://codereview.chromium.org/480023002/diff/60001/media/video/capture/mac/...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/60001/media/video/capture/mac/...
media/video/capture/mac/video_capture_device_mac.h:78: // Forwarder to
VideoCaptureDevice::Client::OnLog().
Nit: empty line before comment.

[mcasas, 2014-08-18 12:26:33]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2014-08-18 12:26:41]

https://codereview.chromium.org/480023002/diff/60001/media/video/capture/mac/...
File media/video/capture/mac/video_capture_device_mac.h (right):

https://codereview.chromium.org/480023002/diff/60001/media/video/capture/mac/...
media/video/capture/mac/video_capture_device_mac.h:78: // Forwarder to
VideoCaptureDevice::Client::OnLog().
On 2014/08/18 12:05:43, Henrik Grunell wrote:
> Nit: empty line before comment.

Done.

[commit-bot: I haz the power, 2014-08-18 12:27:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mcasas@chromium.org/480023002/80001

[commit-bot: I haz the power, 2014-08-18 13:40:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-18 13:45:35]

Committed patchset #4 (80001) as 290250