Mac Video Capture: Change an ErrorMessage to LogMessage

media/video/capture/mac/video_capture_device_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MacOSX implementation of generic VideoCaptureDevice, using either QTKit or
 // AVFoundation as native capture API. QTKit is available in all OSX versions,
 // although namely deprecated in 10.9, and AVFoundation is available in versions
 // 10.7 (Lion) and later.
 
 #ifndef MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_H_
@@ skipping 56 matching lines @@
   bool Init(VideoCaptureDevice::Name::CaptureApiType capture_api_type);
 
   // Called to deliver captured video frames.
   void ReceiveFrame(const uint8* video_frame,
                     int video_frame_length,
                     const VideoCaptureFormat& frame_format,
                     int aspect_numerator,
                     int aspect_denominator);
 
   void ReceiveError(const std::string& reason);
+  void LogMessage(const std::string& message);

[tommi (sloooow) - chröme, 2014/08/18 09:50:06]

This requires some documentation now that it's public.  LogMessage is also
pretty generic.  What is a message in this context and where is this being
logged to?  Should this only be used for errors? Is it for debugging? If not,
what? etc

[mcasas, 2014/08/18 10:47:30]

Done.

 
  private:
   void SetErrorState(const std::string& reason);
-  void LogMessage(const std::string& message);
   bool UpdateCaptureResolution();
 
   // Flag indicating the internal state.
   enum InternalState {
     kNotInitialized,
     kIdle,
     kCapturing,
     kError
   };
 
@@ skipping 18 matching lines @@
   // VideoCaptureDeviceMac is destroyed.
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<VideoCaptureDeviceMac> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureDeviceMac);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_H_