Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 480013002: Do not use raw protocol types in inspector/timeline/timeline-network-resource.html (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
caseq, alph, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Do not use raw protocol types in inspector/timeline/timeline-network-resource.html In preparation to switching to tracing backend the test is changed to use higher level abstractions. BUG=398785 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180451

Patch Set 1 #

Patch Set 2 : Compare record order only on the main thread #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 2 3 chunks +3 lines, -13 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-network-resource.html View 1 2 2 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yurys
6 years, 4 months ago (2014-08-18 08:51:22 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-18 08:52:06 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-18 08:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/480013002/1
6 years, 4 months ago (2014-08-18 08:53:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 09:52:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 10:18:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/21056)
6 years, 4 months ago (2014-08-18 10:18:47 UTC) #7
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-18 11:14:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/480013002/1
6 years, 4 months ago (2014-08-18 11:15:11 UTC) #9
yurys
6 years, 4 months ago (2014-08-18 12:19:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as 180451 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698