Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: LayoutTests/http/tests/inspector/timeline-test.js

Issue 480013002: Do not use raw protocol types in inspector/timeline/timeline-network-resource.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/timeline/timeline-network-resource.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/inspector/timeline-test.js
diff --git a/LayoutTests/http/tests/inspector/timeline-test.js b/LayoutTests/http/tests/inspector/timeline-test.js
index de0d9fb33e3351077767cf019d9bcf2bb42d60e6..01770238ec8e9aa4616677596279545c6ee442d9 100644
--- a/LayoutTests/http/tests/inspector/timeline-test.js
+++ b/LayoutTests/http/tests/inspector/timeline-test.js
@@ -169,7 +169,7 @@ InspectorTest.dumpTimelineRecord = function(record, detailsCallback, level, filt
}
if (detailsCallback)
suffix += " " + detailsCallback(record);
- InspectorTest.addResult(prefix + InspectorTest._timelineAgentTypeToString(record.type()) + suffix);
+ InspectorTest.addResult(prefix + record.type() + suffix);
var children = record.children();
var numChildren = children.length;
@@ -216,7 +216,7 @@ InspectorTest.dumpPresentationRecord = function(presentationRecord, detailsCallb
}
if (detailsCallback)
suffix += " " + detailsCallback(presentationRecord);
- var typeString = record ? InspectorTest._timelineAgentTypeToString(record.type()) : "Root";
+ var typeString = record ? record.type() : "Root";
InspectorTest.addResult(prefix + typeString + suffix);
var numChildren = presentationRecord.presentationChildren() ? presentationRecord.presentationChildren().length : 0;
@@ -235,23 +235,13 @@ InspectorTest.dumpTimelineRecords = function(timelineRecords)
InspectorTest.printTimelineRecordProperties = function(record)
{
- var recordType = (typeof record.type === "string") ? record.type : record.type();
- InspectorTest.addResult(InspectorTest._timelineAgentTypeToString(recordType) + " Properties:");
+ InspectorTest.addResult(record.type() + " Properties:");
// Use this recursive routine to print the properties
if (record instanceof WebInspector.TimelineModel.RecordImpl)
record = record._record;
InspectorTest.addObject(record, InspectorTest.timelinePropertyFormatters);
};
-InspectorTest._timelineAgentTypeToString = function(numericType)
-{
- for (var prop in WebInspector.TimelineModel.RecordType) {
- if (WebInspector.TimelineModel.RecordType[prop] === numericType)
- return prop;
- }
- return undefined;
-};
-
InspectorTest.findFirstTimelineRecord = function(type)
{
var result;
« no previous file with comments | « no previous file | LayoutTests/inspector/timeline/timeline-network-resource.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698