Issue 479733002: [EasyUnlock] Update settings string from "Chrome device" to "Chromebook" or "Chromebox" as appropri…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 479733002: [EasyUnlock] Update settings string from "Chrome device" to "Chromebook" or "Chromebox" as appropri… (Closed)

Created:
6 years, 4 months ago by Ilya Sherman

Modified:
6 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[EasyUnlock] Update settings string from "Chrome device" to "Chromebook" or "Chromebox" as appropriate. BUG=397280 TEST=Open settings UI, search for "Easy unlock", should see "Chromebook" rather than "Chrome device" in the description string. R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290118

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -8 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/chromeos_utils.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/chromeos_utils.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/479733002/1

6 years, 4 months ago (2014-08-15 23:06:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290118

Expand Messages | Collapse Messages