Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5686)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 479733002: [EasyUnlock] Update settings string from "Chrome device" to "Chromebook" or "Chromebox" as appropri… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/chromeos_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 1863c7df00b182bb2e44fefbf9534ebb11f89ef1..50289d3b1b62d28035859569b14ddf0acfdef3a8 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -199,6 +199,13 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
const bool using_new_profiles_ui = switches::IsNewAvatarMenu();
+#if defined(OS_CHROMEOS)
+ const int device_type_resource_id = chromeos::GetChromeDeviceTypeResourceId();
+#else
+ // TODO(isherman): Set an appropriate device name for non-ChromeOS devices.
+ const int device_type_resource_id = IDS_EASY_UNLOCK_GENERIC_DEVICE_TYPE;
+#endif // defined(OS_CHROMEOS)
+
static OptionsStringResource resources[] = {
{ "advancedSectionTitleCloudPrint", IDS_GOOGLE_CLOUD_PRINT },
{ "currentUserOnly", IDS_OPTIONS_CURRENT_USER_ONLY },
@@ -246,10 +253,12 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
{ "downloadLocationGroupName", IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME },
{ "enableLogging", IDS_OPTIONS_ENABLE_LOGGING },
{ "metricsReportingResetRestart", IDS_OPTIONS_ENABLE_LOGGING_RESTART },
- { "easyUnlockDescription", IDS_OPTIONS_EASY_UNLOCK_DESCRIPTION },
+ { "easyUnlockDescription", IDS_OPTIONS_EASY_UNLOCK_DESCRIPTION,
+ device_type_resource_id },
{ "easyUnlockSectionTitle", IDS_OPTIONS_EASY_UNLOCK_SECTION_TITLE },
{ "easyUnlockSetupButton", IDS_OPTIONS_EASY_UNLOCK_SETUP_BUTTON },
- { "easyUnlockSetupIntro", IDS_OPTIONS_EASY_UNLOCK_SETUP_INTRO },
+ { "easyUnlockSetupIntro", IDS_OPTIONS_EASY_UNLOCK_SETUP_INTRO,
+ device_type_resource_id },
{ "extensionControlled", IDS_OPTIONS_TAB_EXTENSION_CONTROLLED },
{ "extensionDisable", IDS_OPTIONS_TAB_EXTENSION_CONTROLLED_DISABLE },
{ "fontSettingsCustomizeFontsButton",
« no previous file with comments | « chrome/browser/chromeos/chromeos_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698