Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Unified Diff: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html

Issue 479723003: Don't add extra items to sheriff-o-matic history. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html
diff --git a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html
index 95df550690d7c53c37e6bbe042849913f6a04d43..9cd66e6a124a6b483a95d4d9fd2665a0a599a830 100644
--- a/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html
+++ b/Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard.html
@@ -32,7 +32,7 @@ found in the LICENSE file.
},
testChanged: function() {
- this.$.iframe.src = this.test.embeddedFlakinessDashboardURL(this.tree);
+ this.$.iframe.contentWindow.location.replace(this.test.embeddedFlakinessDashboardURL(this.tree));
ojan 2014/08/16 01:40:56 Add a comment explaining why we use replace? Also
michaelpg 2014/08/16 02:05:45 It works, but it's weird. You can get a reference
},
});
« no previous file with comments | « Tools/GardeningServer/test/placeholder.html ('k') | Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698