Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 479673004: DevTools: Use workerReadyForInspection event as a signal for DevTools attaching (Closed)

Created:
6 years, 3 months ago by vsevik
Modified:
6 years, 3 months ago
Reviewers:
pfeldman, yurys, horo
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use workerReadyForInspection event as a signal for DevTools attaching BUG=404355 R=yurys, pfeldman-OOO, horo Committed: https://crrev.com/8425e1f3a96becc0c0485ea1033b3f4cefca1277 Cr-Commit-Position: refs/heads/master@{#292387}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fixed test 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M content/browser/devtools/embedded_worker_devtools_agent_host.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 1 2 6 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
horo
lgtm
6 years, 3 months ago (2014-08-27 04:23:42 UTC) #1
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 3 months ago (2014-08-28 06:34:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/479673004/1
6 years, 3 months ago (2014-08-28 06:35:50 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 07:35:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 08:12:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/10898)
6 years, 3 months ago (2014-08-28 08:12:48 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 3 months ago (2014-08-28 13:01:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/479673004/20001
6 years, 3 months ago (2014-08-28 13:02:05 UTC) #8
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 3 months ago (2014-08-28 13:13:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/479673004/40001
6 years, 3 months ago (2014-08-28 13:13:48 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 15:04:10 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 0560d0b9ff63b228670fcc1f0f46f0a262079905
6 years, 3 months ago (2014-08-28 15:38:22 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:59:43 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8425e1f3a96becc0c0485ea1033b3f4cefca1277
Cr-Commit-Position: refs/heads/master@{#292387}

Powered by Google App Engine
This is Rietveld 408576698