Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: content/browser/devtools/embedded_worker_devtools_agent_host.cc

Issue 479673004: DevTools: Use workerReadyForInspection event as a signal for DevTools attaching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test 2 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/embedded_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.cc b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
index cb6b136834df73e699036f641f038962d50bd73f..0eee636efeb9abe4199beff56c24b846d9ccfc25 100644
--- a/content/browser/devtools/embedded_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
@@ -143,13 +143,6 @@ bool EmbeddedWorkerDevToolsAgentHost::OnMessageReceived(
}
void EmbeddedWorkerDevToolsAgentHost::WorkerReadyForInspection() {
- // TODO(vsevik): This method will be implemented once we support connecting
- // devtools to the main thread of embedded worker.
-}
-
-void EmbeddedWorkerDevToolsAgentHost::WorkerContextStarted() {
- // TODO(vsevik): This code should be moved to WorkerReadyForInspection()
- // once we support connecting devtools to the main thread of embedded worker.
if (state_ == WORKER_PAUSED_FOR_DEBUG_ON_START) {
RenderProcessHost* rph = RenderProcessHost::FromID(worker_id_.first);
Inspect(rph->GetBrowserContext());
@@ -161,6 +154,9 @@ void EmbeddedWorkerDevToolsAgentHost::WorkerContextStarted() {
}
}
+void EmbeddedWorkerDevToolsAgentHost::WorkerContextStarted() {
+}
+
void EmbeddedWorkerDevToolsAgentHost::WorkerRestarted(WorkerId worker_id) {
DCHECK_EQ(WORKER_TERMINATED, state_);
state_ = IsAttached() ? WORKER_PAUSED_FOR_REATTACH : WORKER_UNINSPECTED;
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698