Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text.

Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text.

We are adding a --prefer-compositing-to-lcd-text flag to allow promoting
of things that will lose LCD text. Fixed position elements will be the
only thing controlled by this flag in this CL. Other flags will be
merged into it in the future.

R=piman@chromium.org
BUG=365851
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290155

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290191

[danakj, 2014-08-15 21:11:13]

https://codereview.chromium.org/479653003/diff/1/content/browser/android/cont...
File content/browser/android/content_startup_flags.cc (left):

https://codereview.chromium.org/479653003/diff/1/content/browser/android/cont...
content/browser/android/content_startup_flags.cc:56:
switches::kEnableCompositingForFixedPosition);
This comes from OS_ANDROID in the PreferCompositingToLCDText() call to
DeviceScaleEnsuresTextQuality().

https://codereview.chromium.org/479653003/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (left):

https://codereview.chromium.org/479653003/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:377: const char
kEnableHighDpiCompositingForFixedPosition[] =
This flag was just sitting around here doing nothing but getting forwarded to
the renderer.

[danakj, 2014-08-15 21:11:44]

+rsesek for crash_keys.cc

[Robert Sesek, 2014-08-15 21:12:32]

crash_keys.cc LGTM

[danakj, 2014-08-15 21:12:38]

+sky to review, cuz piman@ is OOO

[piman, 2014-08-15 21:21:39]

lgtm

[sky, 2014-08-15 21:21:43]

LGTM - for the record piman was at lunch today.

[piman, 2014-08-15 21:26:29]

On Fri, Aug 15, 2014 at 2:21 PM, <sky@chromium.org> wrote:

> LGTM - for the record piman was at lunch today.
>

Way to spoil my ninja-ness.


>
> https://codereview.chromium.org/479653003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-08-15 21:38:04]

On Fri, Aug 15, 2014 at 5:26 PM, Antoine Labour <piman@chromium.org> wrote:

> On Fri, Aug 15, 2014 at 2:21 PM, <sky@chromium.org> wrote:
>
>> LGTM - for the record piman was at lunch today.
>>
>
>
Way to spoil my ninja-ness.
>

*Sends over 9000 reviews*


>
>
>>
>> https://codereview.chromium.org/479653003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2014-08-16 15:13:05]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-16 15:13:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/479653003/1

[commit-bot: I haz the power, 2014-08-16 16:39:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-16 17:51:22]

Committed patchset #1 (1) as 290155

[tdanderson, 2014-08-16 20:42:08]

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/484473002/ by tdanderson@chromium.org.

The reason for reverting is: Reverting due to compile step failure on Linux
ChromiumOS Builder (dbg) (see
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[danakj, 2014-08-17 01:41:32]

I should have CONTENT_EXPORTed the switched but I didn't cuz everything passed
the CQ and I didn't want to add it if not needed. Added now.

[danakj, 2014-08-17 01:41:41]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-08-17 01:41:51]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2014-08-17 01:42:51]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-17 01:44:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/479653003/20001

[commit-bot: I haz the power, 2014-08-17 04:40:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-17 05:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-17 05:26:43]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2014-08-17 14:09:02]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-17 14:09:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/479653003/20001

[commit-bot: I haz the power, 2014-08-17 14:55:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-17 18:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-17 18:39:08]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2014-08-17 20:08:11]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-08-17 20:08:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/479653003/20001

[commit-bot: I haz the power, 2014-08-17 20:09:15]

Committed patchset #2 (20001) as 290191