Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: tools/image_expectations.h

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Cleanup and add to gm_json.py Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/image_expectations.h
diff --git a/tools/image_expectations.h b/tools/image_expectations.h
index ae1df193548f90fec65f73af9e12b722539b6b64..d920ec618c9279ae9f3d7f49bcf3c570d348f9fe 100644
--- a/tools/image_expectations.h
+++ b/tools/image_expectations.h
@@ -119,6 +119,13 @@ namespace sk_tools {
void addDescription(const char *key, const char *value);
/**
+ * Adds a Google Storage Bucket to the summary of results.
+ *
+ * @param bucket the Google Storage bucket
+ */
+ void setGoogleStorageBucket(const char *bucket);
+
+ /**
* Returns true if this test result matches its expectations.
* If there are no expectations for this test result, this will return false.
*
@@ -151,6 +158,7 @@ namespace sk_tools {
Json::Value fDescriptions;
Json::Value fExpectedJsonRoot;
Json::Value fExpectedResults;
+ Json::Value fGoogleStorageBucket;
};
} // namespace sk_tools
« gm/gm_json.py ('K') | « gm/gm_json.py ('k') | tools/image_expectations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698