gm/gm_json.py - Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/gm_json.py

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Cleanup and add to gm_json.py Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/gm_json.py

diff --git a/gm/gm_json.py b/gm/gm_json.py

index 6a91cc4f513599563e14669e67dafa8931c845da..ec80436cc678f56c366df42f8185d0a1c15079b8 100644

--- a/gm/gm_json.py

+++ b/gm/gm_json.py

@@ -93,6 +93,7 @@ JSONKEY_IMAGE_COMPARISONRESULT = 'comparisonResult'

JSONKEY_IMAGE_FILEPATH = 'filepath'

JSONKEY_SOURCE_TILEDIMAGES = 'tiled-images'

JSONKEY_SOURCE_WHOLEIMAGE = 'whole-image'

+JSONKEY_GOOGLE_STORAGE_BUCKET = 'gs-bucket'

epoger 2014/08/15 17:52:50 I think this CL is fine *except* that I think it w

rmistry 2014/08/21 13:08:29 Done.

# Root directory where the buildbots store their actually-generated images...

« no previous file with comments | « no previous file | tools/image_expectations.h » ('j') | no next file with comments »