Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: tools/image_expectations.cpp

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Cleanup and add to gm_json.py Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/image_expectations.cpp
diff --git a/tools/image_expectations.cpp b/tools/image_expectations.cpp
index dfc2638a9e28406c70994111c8a09b7a17f95c14..6180ffce708a881f8a1708a277b84b3308952f1a 100644
--- a/tools/image_expectations.cpp
+++ b/tools/image_expectations.cpp
@@ -30,6 +30,7 @@
const static char kJsonKey_ActualResults[] = "actual-results";
const static char kJsonKey_Descriptions[] = "descriptions";
const static char kJsonKey_ExpectedResults[] = "expected-results";
+const static char kJsonKey_GoogleStorageBucket[] = "gs-bucket";
const static char kJsonKey_Header[] = "header";
const static char kJsonKey_Header_Type[] = "type";
const static char kJsonKey_Header_Revision[] = "revision";
@@ -182,6 +183,10 @@ namespace sk_tools {
fDescriptions[key] = value;
}
+ void ImageResultsAndExpectations::setGoogleStorageBucket(const char *bucket) {
+ fGoogleStorageBucket = bucket;
+ }
+
bool ImageResultsAndExpectations::matchesExpectation(const char *sourceName,
const ImageDigest &digest,
const int *tileNumber) {
@@ -213,6 +218,7 @@ namespace sk_tools {
root[kJsonKey_ActualResults] = fActualResults;
root[kJsonKey_Descriptions] = fDescriptions;
root[kJsonKey_Header] = header;
+ root[kJsonKey_GoogleStorageBucket] = fGoogleStorageBucket;
std::string jsonStdString = root.toStyledString();
SkFILEWStream stream(filename);
stream.write(jsonStdString.c_str(), jsonStdString.length());
« gm/gm_json.py ('K') | « tools/image_expectations.h ('k') | tools/render_pictures_main.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698