Issue 479493002: Rename minRepetitions to maxRepetitions and clamp with min()

Issue 479493002: Rename minRepetitions to maxRepetitions and clamp with min() (Closed)

Created:
6 years, 4 months ago by Timothy Loh

Modified:
6 years, 4 months ago

Reviewers:
jfernandez, alancutter (OOO until 2018)

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename minRepetitions to maxRepetitions and clamp with min() The value minRepetitions is actually used as an upper bound. Looks like this was a misunderstanding of a review comment in https://codereview.chromium.org/251643002. BUG=404023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180331

Patch Set 1 #

Total comments: 2

Patch Set 2 : move constant to inside function #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/core/css/parser/CSSPropertyParser.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alancutter (OOO until 2018)

lgtm with nit. https://codereview.chromium.org/479493002/diff/1/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/479493002/diff/1/Source/core/css/parser/CSSPropertyParser.cpp#newcode88 Source/core/css/parser/CSSPropertyParser.cpp:88: static const size_t maxRepetitions = 10000; ...

6 years, 4 months ago (2014-08-15 05:06:43 UTC) #2

Timothy Loh

https://codereview.chromium.org/479493002/diff/1/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/479493002/diff/1/Source/core/css/parser/CSSPropertyParser.cpp#newcode88 Source/core/css/parser/CSSPropertyParser.cpp:88: static const size_t maxRepetitions = 10000; On 2014/08/15 05:06:42, ...

6 years, 4 months ago (2014-08-15 05:29:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/479493002/20001

6 years, 4 months ago (2014-08-15 05:29:21 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 06:27:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180331

Expand Messages | Collapse Messages