Issue 251643002: [CSS Grid Layout] Clamping the number of repetitions when using the repeat() function.

Issue 251643002: [CSS Grid Layout] Clamping the number of repetitions when using the repeat() function. (Closed)

Created:
6 years, 8 months ago by jfernandez

Modified:
6 years, 7 months ago

Reviewers:
eseidel, esprehn, Julien - ping for review

CC:
blink-reviews, jfernandez, svillar, Manuel Rego, ed+blinkwatch_opera.com, ojan, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Clamping the number of repetitions when using the repeat() function. The ED suggests now to be able to clamp the number of repetitions when using the repeat() function, taking precautions about excessive memory usage. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173031

Patch Set 1 #

Total comments: 5

Patch Set 2 : Applied suggested changes. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
A	LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions-expected.txt	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

lgtm https://codereview.chromium.org/251643002/diff/1/LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html File LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html (right): https://codereview.chromium.org/251643002/diff/1/LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html#newcode1 LayoutTests/fast/css-grid-layout/grid-element-repeat-max-repetitions.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> Let's stick with ...

6 years, 8 months ago (2014-04-25 15:50:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfernandez@igalia.com/251643002/20001

6 years, 7 months ago (2014-04-30 20:21:28 UTC) #4

Message was sent while issue was closed.

Change committed as 173031

Expand Messages | Collapse Messages