Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 47923018: Move FeatureSwitch to top-level extensions/ (Closed)

Created:
7 years, 1 month ago by Devlin
Modified:
7 years, 1 month ago
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, chromium-apps-reviews_chromium.org, miu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move FeatureSwitch to top-level extensions/ Move FeatureSwitch to extensions/common/ Move the switches used in FeatureSwitch to extensions/common/switches.h (when necessary). Update some uses of the switches to use feature switch instead of the commandline BUG=159265 TBR=rdsmith@chromium.org (c/b/download) TBR=sky@chromium.org (c/b/ui/, c/test/ui/) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233977

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -315 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_badge_controller_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_bubble_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 4 chunks +0 lines, -20 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/command.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/feature_switch.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/extensions/feature_switch.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M chrome/common/extensions/feature_switch_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + extensions/common/feature_switch.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/feature_switch.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M extensions/common/switches.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/switches.cc View 1 2 chunks +21 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
7 years, 1 month ago (2013-10-31 21:08:01 UTC) #1
Yoyo Zhou
LGTM
7 years, 1 month ago (2013-10-31 23:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/47923018/310001
7 years, 1 month ago (2013-11-08 18:30:14 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 20:43:02 UTC) #4
Message was sent while issue was closed. 
Change committed as 233977

Powered by Google App Engine
This is Rietveld 408576698