chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc - Issue 47923018: Move FeatureSwitch to top-level extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

Issue 47923018: Move FeatureSwitch to top-level extensions/ (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/extensions/api/extension_action/script_badge_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

index 17bd878c23213caf94474909964be6049ea4b4e3..0363c5c77c5a4c005a6d5e7c8d419da073e1a72a 100644

--- a/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc

@@ -19,10 +19,10 @@

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/omnibox/location_bar.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/public/browser/web_contents.h"

+#include "extensions/common/feature_switch.h"

// These are a mash-up of the tests from from page_actions_apitest.cc and

// browser_actions_apitest.cc.

@@ -35,9 +35,10 @@ class PageAsBrowserActionApiTest : public ExtensionApiTest {

PageAsBrowserActionApiTest() {}

virtual ~PageAsBrowserActionApiTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {

- ExtensionApiTest::SetUpCommandLine(command_line);

- command_line->AppendSwitchASCII(switches::kScriptBadges, "1");

+ virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {

+ ExtensionApiTest::SetUpInProcessBrowserTestFixture();

+ FeatureSwitch::script_badges()->SetOverrideValue(

+ FeatureSwitch::OVERRIDE_ENABLED);

}

protected: