Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/notification_types.h

Issue 479: DidNavigate refactor of doom (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/navigation_controller_unittest.cc ('K') | « chrome/browser/web_contents_unittest.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/notification_types.h
===================================================================
--- chrome/common/notification_types.h (revision 1840)
+++ chrome/common/notification_types.h (working copy)
@@ -67,6 +67,10 @@
// Indicates that a NavigationEntry has changed. The source will be the
// NavigationController that owns the NavigationEntry. The details will be
// a NavigationController::EntryChangedDetails struct.
+ //
+ // This will NOT be sent on navigation, interested parties should also listen
+ // for NOTIFY_NAV_ENTRY_COMMITTED to handle that case. This will be sent when
+ // the entry is updated outside of navigation (like when a new title comes).
NOTIFY_NAV_ENTRY_CHANGED,
// Other load-related (not from NavigationController) ------------------------
« chrome/browser/navigation_controller_unittest.cc ('K') | « chrome/browser/web_contents_unittest.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698