DidNavigate refactor of doom

chrome/common/notification_types.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file describes various types used to describe and filter notifications
 // that pass through the NotificationService.
 
 #ifndef CHROME_COMMON_NOTIFICATION_TYPES_H__
 #define CHROME_COMMON_NOTIFICATION_TYPES_H__
 
@@ skipping 49 matching lines @@
   // The details are an integer indicating the number of items pruned.
   // Watch out: the NavigationController may start throwing entries away once
   // the list is a certain size, so you can't use the current size of the
   // navigation list to tell how many items were pruned, you have to use the
   // details provided here.
   NOTIFY_NAV_LIST_PRUNED,
 
   // Indicates that a NavigationEntry has changed. The source will be the
   // NavigationController that owns the NavigationEntry. The details will be
   // a NavigationController::EntryChangedDetails struct.
+  //
+  // This will NOT be sent on navigation, interested parties should also listen
+  // for NOTIFY_NAV_ENTRY_COMMITTED to handle that case. This will be sent when
+  // the entry is updated outside of navigation (like when a new title comes).
   NOTIFY_NAV_ENTRY_CHANGED,
 
   // Other load-related (not from NavigationController) ------------------------
 
   // A content load is starting.  The source will be a
   // Source<NavigationController> corresponding to the tab
   // in which the load is occurring.  No details are
   // expected for this notification.
   NOTIFY_LOAD_START,
 
@@ skipping 390 matching lines @@
   NOTIFY_PERSONALIZATION,
 
   // Count (must be last) ------------------------------------------------------
   // Used to determine the number of notification types.  Not valid as
   // a type parameter when registering for or posting notifications.
   NOTIFICATION_TYPE_COUNT
 };
 
 #endif  // CHROME_COMMON_NOTIFICATION_TYPES_H__