Issue 478953002: DevTools: [MQI] add tooltips for ruler serifs

Issue 478953002: DevTools: [MQI] add tooltips for ruler serifs (Closed)

Created:
6 years, 4 months ago by lushnikov

Modified:
6 years, 4 months ago

Reviewers:
dgozman, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [MQI] add tooltips for ruler serifs The patch adds tooltips with actual pixel values of serifs, representing CSS breakpoints on CSS ruler. BUG=391240 R=pfeldman, dgozman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180411

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/devtools/front_end/toolbox/MediaQueryInspector.js	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dgozman

lgtm https://codereview.chromium.org/478953002/diff/1/Source/devtools/front_end/toolbox/MediaQueryInspector.js File Source/devtools/front_end/toolbox/MediaQueryInspector.js (right): https://codereview.chromium.org/478953002/diff/1/Source/devtools/front_end/toolbox/MediaQueryInspector.js#newcode360 Source/devtools/front_end/toolbox/MediaQueryInspector.js:360: thresholdElement.title = thresholds[i] + "px"; Do you think ...

6 years, 4 months ago (2014-08-16 17:54:13 UTC) #2

lushnikov

https://codereview.chromium.org/478953002/diff/1/Source/devtools/front_end/toolbox/MediaQueryInspector.js File Source/devtools/front_end/toolbox/MediaQueryInspector.js (right): https://codereview.chromium.org/478953002/diff/1/Source/devtools/front_end/toolbox/MediaQueryInspector.js#newcode360 Source/devtools/front_end/toolbox/MediaQueryInspector.js:360: thresholdElement.title = thresholds[i] + "px"; On 2014/08/16 17:54:13, dgozman ...

6 years, 4 months ago (2014-08-16 18:18:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/478953002/1

6 years, 4 months ago (2014-08-16 18:19:48 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-16 19:19:24 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 180411

Expand Messages | Collapse Messages